Release/122.0.0 #3996
Merged
Release/122.0.0 #3996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BelfordZ
commented
Feb 28, 2024
BelfordZ
commented
Feb 28, 2024
adonesky1
reviewed
Feb 28, 2024
mcmire
previously requested changes
Feb 29, 2024
There was a problem hiding this comment.
It looks like @metamask/permission-controller was added as a dev dependency to @metamask/selected-network-controller in #3969. It needs to be in the dependencies field as the import is showing up in the type declaration file. It also needs to be added as a peer dependency since SelectedNetworkController is talking to PermissionsController. Is it possible to add a new PR with those changes before merging this?
Closed
3 tasks
mcmire
reviewed
Feb 29, 2024
BelfordZ
added a commit
that referenced
this pull request
Feb 29, 2024
## Explanation in response to #3996 (review) ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? For example: * Fixes #12345 * Related to #67890 --> ## Changelog <!-- If you're making any consumer-facing changes, list those changes here as if you were updating a changelog, using the template below as a guide. (CATEGORY is one of BREAKING, ADDED, CHANGED, DEPRECATED, REMOVED, or FIXED. For security-related issues, follow the Security Advisory process.) Please take care to name the exact pieces of the API you've added or changed (e.g. types, interfaces, functions, or methods). If there are any breaking changes, make sure to offer a solution for consumers to follow once they upgrade to the changes. Finally, if you're only making changes to development scripts or tests, you may replace the template below with "None". --> ### `@metamask/selected-network-controller` - **CHANGED**: Move permissions-controller from devDeps to deps and peerDep ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate
Co-authored-by: Alex Donesky <adonesky@gmail.com>
BelfordZ
force-pushed
the
release/122.0.0
branch
from
16595b3 to
07798ed
Compare
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
adonesky1
reviewed
Feb 29, 2024
Co-authored-by: Alex Donesky <adonesky@gmail.com>
mcmire
reviewed
Feb 29, 2024
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
|
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
References
Changelog
@metamask/package-a@metamask/package-bChecklist