Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move permission controller from devdep to regular dep #4000

Merged
merged 1 commit into from
Feb 29, 2024
Merged

move permission controller from devdep to regular dep #4000

merged 1 commit into from
Feb 29, 2024

Conversation

BelfordZ
Copy link
Contributor

@BelfordZ BelfordZ commented Feb 29, 2024 •
edited
Loading

Explanation

in response to #3996 (review)

References

Changelog

@metamask/selected-network-controller

  • CHANGED: Move permissions-controller from devDeps to deps and peerDep

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@BelfordZ BelfordZ requested a review from a team as a code owner February 29, 2024 18:22
mcmire
mcmire approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good.

@mcmire mcmire mentioned this pull request Feb 29, 2024
Merged
3 tasks
@BelfordZ BelfordZ merged commit e7b3e4b into main Feb 29, 2024
139 checks passed
@BelfordZ BelfordZ deleted the fix-selected-network-deps branch February 29, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmire mcmire mcmire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BelfordZ @mcmire