Release 184.0.0 #4607
Merged
Release 184.0.0 #4607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
reviewed
Aug 13, 2024
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
sleepytanya
approved these changes
Aug 13, 2024
MajorLift
reviewed
Aug 13, 2024
|
|
||
| ### Fixed | ||
|
|
||
| - Fix SafeEventEmitterProvider invalid default params ([#4603](https://github.com/MetaMask/core/pull/4603)) |
There was a problem hiding this comment.
Looks like there's more detail in the PR description that we could supply here. Currently the entry is a bit vague.
Suggested change
| - Fix SafeEventEmitterProvider invalid default params ([#4603](https://github.com/MetaMask/core/pull/4603)) | |
| - Fix the `params` property of the `SafeEventEmitterProvider` class EIP-1193 request object so that its default value is an empty array, not an empty object ([#4603](https://github.com/MetaMask/core/pull/4603)) | |
| - Fixes `SafeEventEmitterProvider` failure to send `net_version` requests correctly. | |
| - In general, passing an empty object `params` property into a method that has array parameters can result in failure. | |
| - This issue was introduced in `4.1.0`. |
There was a problem hiding this comment.
For a Fixed entry, we should also add info about where the bug was introduced wherever possible (edited above comment).
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Release PR to release
@metamask/eth-json-rpc-provider. This includes the bugfix of SafeEventEmitterProvider invalid default params.References