Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 184.0.0 #4607

Merged
merged 4 commits into from
Aug 13, 2024
Merged

Release 184.0.0 #4607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
081b0dc
Initialize Release 184.0.0
kanthesha Aug 13, 2024
8fbcc0f
Update Release 184.0.0
kanthesha Aug 13, 2024
ab9eff5
Release 184.0.0
kanthesha Aug 13, 2024
0ff396a
Update packages/eth-json-rpc-provider/CHANGELOG.md
kanthesha Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@metamask/core-monorepo",
"version": "183.0.0",
"version": "184.0.0",
"private": true,
"description": "Monorepo for packages shared between MetaMask clients",
"repository": {
Expand Down Expand Up @@ -56,7 +56,7 @@
"@metamask/eslint-config-nodejs": "^12.1.0",
"@metamask/eslint-config-typescript": "^12.1.0",
"@metamask/eth-block-tracker": "^9.0.3",
"@metamask/eth-json-rpc-provider": "^4.1.2",
"@metamask/eth-json-rpc-provider": "^4.1.3",
"@metamask/json-rpc-engine": "^9.0.2",
"@metamask/utils": "^9.1.0",
"@types/jest": "^27.4.1",
Expand Down
13 changes: 12 additions & 1 deletion packages/eth-json-rpc-provider/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [4.1.3]

### Changed

- Bump `typescript` from `~5.0.4` to `~5.2.2` ([#4576](https://github.com/MetaMask/core/pull/4576), [#4584](https://github.com/MetaMask/core/pull/4584))

### Fixed

- Fix SafeEventEmitterProvider invalid default params ([#4603](https://github.com/MetaMask/core/pull/4603))
Copy link
Contributor

@MajorLift MajorLift Aug 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's more detail in the PR description that we could supply here. Currently the entry is a bit vague.

Suggested change
- Fix SafeEventEmitterProvider invalid default params ([#4603](https://github.com/MetaMask/core/pull/4603))
- Fix the `params` property of the `SafeEventEmitterProvider` class EIP-1193 request object so that its default value is an empty array, not an empty object ([#4603](https://github.com/MetaMask/core/pull/4603))
- Fixes `SafeEventEmitterProvider` failure to send `net_version` requests correctly.
- In general, passing an empty object `params` property into a method that has array parameters can result in failure.
- This issue was introduced in `4.1.0`.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a Fixed entry, we should also add info about where the bug was introduced wherever possible (edited above comment).


## [4.1.2]

### Changed
Expand Down Expand Up @@ -134,7 +144,8 @@ Release `v2.0.0` is identical to `v1.0.1` aside from Node.js version requirement

- Initial release, including `providerFromEngine` and `providerFromMiddleware`.

[Unreleased]: https://github.com/MetaMask/core/compare/@metamask/eth-json-rpc-provider@4.1.2...HEAD
[Unreleased]: https://github.com/MetaMask/core/compare/@metamask/eth-json-rpc-provider@4.1.3...HEAD
[4.1.3]: https://github.com/MetaMask/core/compare/@metamask/eth-json-rpc-provider@4.1.2...@metamask/eth-json-rpc-provider@4.1.3
[4.1.2]: https://github.com/MetaMask/core/compare/@metamask/eth-json-rpc-provider@4.1.1...@metamask/eth-json-rpc-provider@4.1.2
[4.1.1]: https://github.com/MetaMask/core/compare/@metamask/eth-json-rpc-provider@4.1.0...@metamask/eth-json-rpc-provider@4.1.1
[4.1.0]: https://github.com/MetaMask/core/compare/@metamask/eth-json-rpc-provider@4.0.0...@metamask/eth-json-rpc-provider@4.1.0
Expand Down
2 changes: 1 addition & 1 deletion packages/eth-json-rpc-provider/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@metamask/eth-json-rpc-provider",
"version": "4.1.2",
"version": "4.1.3",
"description": "Create an Ethereum provider using a JSON-RPC engine or middleware",
"keywords": [
"MetaMask",
Expand Down
2 changes: 1 addition & 1 deletion packages/network-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"@metamask/eth-block-tracker": "^9.0.3",
"@metamask/eth-json-rpc-infura": "^9.1.0",
"@metamask/eth-json-rpc-middleware": "^12.1.1",
"@metamask/eth-json-rpc-provider": "^4.1.2",
"@metamask/eth-json-rpc-provider": "^4.1.3",
"@metamask/eth-query": "^4.0.0",
"@metamask/json-rpc-engine": "^9.0.2",
"@metamask/rpc-errors": "^6.3.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/transaction-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
"@metamask/accounts-controller": "^18.0.0",
"@metamask/approval-controller": "^7.0.2",
"@metamask/auto-changelog": "^3.4.4",
"@metamask/eth-json-rpc-provider": "^4.1.2",
"@metamask/eth-json-rpc-provider": "^4.1.3",
"@metamask/ethjs-provider-http": "^0.3.0",
"@metamask/gas-fee-controller": "^19.0.1",
"@metamask/keyring-api": "^8.1.0",
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2562,7 +2562,7 @@ __metadata:
"@metamask/eslint-config-nodejs": "npm:^12.1.0"
"@metamask/eslint-config-typescript": "npm:^12.1.0"
"@metamask/eth-block-tracker": "npm:^9.0.3"
"@metamask/eth-json-rpc-provider": "npm:^4.1.2"
"@metamask/eth-json-rpc-provider": "npm:^4.1.3"
"@metamask/json-rpc-engine": "npm:^9.0.2"
"@metamask/utils": "npm:^9.1.0"
"@types/jest": "npm:^27.4.1"
Expand Down Expand Up @@ -2775,7 +2775,7 @@ __metadata:
languageName: node
linkType: hard

"@metamask/eth-json-rpc-provider@npm:^4.1.2, @metamask/eth-json-rpc-provider@workspace:packages/eth-json-rpc-provider":
"@metamask/eth-json-rpc-provider@npm:^4.1.3, @metamask/eth-json-rpc-provider@workspace:packages/eth-json-rpc-provider":
version: 0.0.0-use.local
resolution: "@metamask/eth-json-rpc-provider@workspace:packages/eth-json-rpc-provider"
dependencies:
Expand Down Expand Up @@ -3248,7 +3248,7 @@ __metadata:
"@metamask/eth-block-tracker": "npm:^9.0.3"
"@metamask/eth-json-rpc-infura": "npm:^9.1.0"
"@metamask/eth-json-rpc-middleware": "npm:^12.1.1"
"@metamask/eth-json-rpc-provider": "npm:^4.1.2"
"@metamask/eth-json-rpc-provider": "npm:^4.1.3"
"@metamask/eth-query": "npm:^4.0.0"
"@metamask/json-rpc-engine": "npm:^9.0.2"
"@metamask/rpc-errors": "npm:^6.3.1"
Expand Down Expand Up @@ -3941,7 +3941,7 @@ __metadata:
"@metamask/auto-changelog": "npm:^3.4.4"
"@metamask/base-controller": "npm:^6.0.2"
"@metamask/controller-utils": "npm:^11.0.2"
"@metamask/eth-json-rpc-provider": "npm:^4.1.2"
"@metamask/eth-json-rpc-provider": "npm:^4.1.3"
"@metamask/eth-query": "npm:^4.0.0"
"@metamask/ethjs-provider-http": "npm:^0.3.0"
"@metamask/gas-fee-controller": "npm:^19.0.1"
Expand Down
Loading