feat: integrating signature decoding api #4855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpuri
commented
Oct 29, 2024
matthewwalsh0
requested changes
Oct 29, 2024
matthewwalsh0
requested changes
Nov 5, 2024
matthewwalsh0
requested changes
Nov 6, 2024
| @@ -0,0 +1,8 @@ | |||
| export const EthMethod = { | |||
There was a problem hiding this comment.
Minor, this feels more like an enum as it's a fixed set of values to identify a type of something.
Which would also mean it could go in types.ts.
But we can do this later since it's not exported.
There was a problem hiding this comment.
I tried that but it is giving build issues somehow.
matthewwalsh0
approved these changes
Nov 7, 2024
7 tasks
jpuri
added a commit
that referenced
this pull request
Nov 8, 2024
## Explanation Signature controller update that add decoding api integration. ## References * Related to [#67890](MetaMask/MetaMask-planning#3553) ## Changelog ### `@metamask/signature-controller` - **ADDED**: Add isDecodeSignatureRequestEnabled to SignatureController constructor to be able to check if decoding api should be invoked for the signature ([#4903](#4903)) - **ADDED**: Integrating signature decoding api ([#4855](#4855)) ## Checklist - [X] I've updated the test suite for new or updated code as appropriate - [X] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [X] I've highlighted breaking changes using the "BREAKING" category above as appropriate - [X] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Integrate signature decoding api in signature-controller. When a permit request is received this api is called and the result is asynchronously updated into signature request.
References
Changelog
@metamask/signature-controllerChecklist