Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/243.0.0 #4908

Merged
merged 8 commits into from
Nov 8, 2024
Merged

Release/243.0.0 #4908

merged 8 commits into from
Nov 8, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Nov 8, 2024

Explanation

Signature controller update that add decoding api integration.

References

Changelog

@metamask/signature-controller

  • ADDED: Add isDecodeSignatureRequestEnabled to SignatureController constructor to be able to check if decoding api should be invoked for the signature (#4903)
  • ADDED: Integrating signature decoding api (#4855)

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@jpuri jpuri requested review from a team as code owners November 8, 2024 13:53
@jpuri jpuri enabled auto-merge (squash) November 8, 2024 15:03
matthewwalsh0
matthewwalsh0 requested changes Nov 8, 2024
View reviewed changes
packages/signature-controller/package.json Outdated Show resolved Hide resolved
packages/signature-controller/CHANGELOG.md Outdated Show resolved Hide resolved
packages/signature-controller/CHANGELOG.md Outdated Show resolved Hide resolved
packages/signature-controller/CHANGELOG.md Outdated Show resolved Hide resolved
@jpuri jpuri requested a review from matthewwalsh0 November 8, 2024 15:26
@jpuri jpuri merged commit d18e7f8 into main Nov 8, 2024
120 checks passed
@jpuri jpuri deleted the release/243.0.0 branch November 8, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewwalsh0 matthewwalsh0 matthewwalsh0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpuri @matthewwalsh0