Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adjust network names #4865

Merged
merged 3 commits into from
Nov 4, 2024
Merged

fix: adjust network names #4865

merged 3 commits into from
Nov 4, 2024

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Oct 29, 2024 •
edited
Loading

Explanation

The current state of the network nickname mappings does not fully align with the naming conventions used by third-party providers, leading to potential inconsistencies and confusion. Specifically, the names "Mainnet" and "Linea Mainnet" do not match the standard conventions of "Ethereum Mainnet" and "Linea." Updating these nicknames helps ensure clarity and consistency across platforms.

The proposed changes standardize the network names by updating Mainnet to Ethereum Mainnet and Linea Mainnet to Linea. This provides better alignment with widely accepted naming conventions, making it easier for consumers to understand and trust the network names displayed.

References

This change aligns the network names with conventions used by third-party providers for Ethereum mainnet and Linea mainnet.

  • Related to #67890

Changelog

@metamask/controller-utils

  • CHANGED: Updated network nickname for Mainnet to Ethereum Mainnet to standardize with third-party naming.
  • CHANGED: Updated network nickname for Linea Mainnet to Linea for consistency.

@metamask/network-controller

  • CHANGED: Updated network nickname for Mainnet to Ethereum Mainnet to pass the unit tests.

Checklist

  • I've updated the test suite for new or updated code as appropriate.
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate.
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate.
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes.

@salimtb salimtb mentioned this pull request Oct 29, 2024
Merged
7 tasks
@salimtb salimtb marked this pull request as ready for review October 29, 2024 14:44
@salimtb salimtb requested review from a team as code owners October 29, 2024 14:44
github-merge-queue bot pushed a commit to MetaMask/metamask-mobile that referenced this pull request Oct 29, 2024
@salimtb
fix: fix naming for linea and mainnet (#12074)
627ed0c 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
The network names for Ethereum mainnet and Linea mainnet should be
standardized as "Ethereum Mainnet" and "Linea" to align with our
third-party provider.

core PR: [adjust network
names](MetaMask/core#4865)
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Related issues**

Fixes: #11895 

## **Manual testing steps**

1. Move from v7.33 ( or any previous release version ) to this branch
2. Check the name of Ethereum mainnet and Linea

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**
<img width="416" alt="Screenshot 2024-10-29 at 14 57 00"
src="https://github.com/user-attachments/assets/a00a61ce-a5be-4398-951d-6479a14c8b7b">


<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->
<img width="440" alt="Screenshot 2024-10-29 at 14 56 53"
src="https://github.com/user-attachments/assets/24999468-1c80-4dc4-9bb3-6b68a780f633">


## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
salimtb added a commit to MetaMask/metamask-mobile that referenced this pull request Oct 29, 2024
@salimtb
fix: fix naming for linea and mainnet (#12074)
2c2a32a 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

The network names for Ethereum mainnet and Linea mainnet should be
standardized as "Ethereum Mainnet" and "Linea" to align with our
third-party provider.

core PR: [adjust network
names](MetaMask/core#4865)
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

Fixes: #11895

1. Move from v7.33 ( or any previous release version ) to this branch
2. Check the name of Ethereum mainnet and Linea

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

<img width="416" alt="Screenshot 2024-10-29 at 14 57 00"
src="https://github.com/user-attachments/assets/a00a61ce-a5be-4398-951d-6479a14c8b7b">

<!-- [screenshots/recordings] -->

<!-- [screenshots/recordings] -->
<img width="440" alt="Screenshot 2024-10-29 at 14 56 53"
src="https://github.com/user-attachments/assets/24999468-1c80-4dc4-9bb3-6b68a780f633">

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@salimtb salimtb mentioned this pull request Oct 29, 2024
Merged
7 tasks
salimtb added a commit to MetaMask/metamask-mobile that referenced this pull request Oct 29, 2024
@salimtb
fix: fix naming for linea and mainnet (#12074)
9dae0ba 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

The network names for Ethereum mainnet and Linea mainnet should be
standardized as "Ethereum Mainnet" and "Linea" to align with our
third-party provider.

core PR: [adjust network
names](MetaMask/core#4865)
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

Fixes: #11895

1. Move from v7.33 ( or any previous release version ) to this branch
2. Check the name of Ethereum mainnet and Linea

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

<img width="416" alt="Screenshot 2024-10-29 at 14 57 00"
src="https://github.com/user-attachments/assets/a00a61ce-a5be-4398-951d-6479a14c8b7b">

<!-- [screenshots/recordings] -->

<!-- [screenshots/recordings] -->
<img width="440" alt="Screenshot 2024-10-29 at 14 56 53"
src="https://github.com/user-attachments/assets/24999468-1c80-4dc4-9bb3-6b68a780f633">

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
sethkfman pushed a commit to MetaMask/metamask-mobile that referenced this pull request Oct 29, 2024
@salimtb
chore: cherry pick 12074 (#12082)
648ec70 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
The network names for Ethereum mainnet and Linea mainnet should be
standardized as "Ethereum Mainnet" and "Linea" to align with our
third-party provider.

core PR: [adjust network
names](MetaMask/core#4865)
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Related issues**

Fixes: #11895 

## **Manual testing steps**

1. Move from v7.33 ( or any previous release version ) to this branch
2. Check the name of Ethereum mainnet and Linea

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**


<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->



## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
mcmire
mcmire approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no problems with this. Makes sense to me.

@salimtb salimtb merged commit 951e026 into main Nov 4, 2024
120 checks passed
@salimtb salimtb deleted the salim/adjust-network-name branch November 4, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptodev-2s cryptodev-2s cryptodev-2s approved these changes

@mcmire mcmire mcmire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@salimtb @mcmire @cryptodev-2s