chore: cherry pick 12074 #12082
Merged
chore: cherry pick 12074 #12082
+39
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> The network names for Ethereum mainnet and Linea mainnet should be standardized as "Ethereum Mainnet" and "Linea" to align with our third-party provider. core PR: [adjust network names](MetaMask/core#4865) <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Fixes: #11895 1. Move from v7.33 ( or any previous release version ) to this branch 2. Check the name of Ethereum mainnet and Linea <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> <img width="416" alt="Screenshot 2024-10-29 at 14 57 00" src="https://github.com/user-attachments/assets/a00a61ce-a5be-4398-951d-6479a14c8b7b"> <!-- [screenshots/recordings] --> <!-- [screenshots/recordings] --> <img width="440" alt="Screenshot 2024-10-29 at 14 56 53" src="https://github.com/user-attachments/assets/24999468-1c80-4dc4-9bb3-6b68a780f633"> - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
salimtb
force-pushed
the
chore/cherry-pick-12074
branch
from
2c2a32a
to
9dae0ba
Compare
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The network names for Ethereum mainnet and Linea mainnet should be standardized as "Ethereum Mainnet" and "Linea" to align with our third-party provider.
core PR: adjust network names
Related issues
Fixes: #11895
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist