Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry pick 12074 #12082

Merged
merged 2 commits into from
Oct 29, 2024
Merged

chore: cherry pick 12074 #12082

merged 2 commits into from
Oct 29, 2024

Commits on Oct 29, 2024

  1. fix: fix naming for linea and mainnet (#12074)

    <!--
    Please submit this PR as a draft initially.
    Do not mark it as "Ready for review" until the template has been
    completely filled out, and PR status checks have passed at least once.
    -->
    
    The network names for Ethereum mainnet and Linea mainnet should be
    standardized as "Ethereum Mainnet" and "Linea" to align with our
    third-party provider.
    
    core PR: [adjust network
    names](MetaMask/core#4865)
    <!--
    Write a short description of the changes included in this pull request,
    also include relevant motivation and context. Have in mind the following
    questions:
    1. What is the reason for the change?
    2. What is the improvement/solution?
    -->
    
    Fixes: #11895
    
    1. Move from v7.33 ( or any previous release version ) to this branch
    2. Check the name of Ethereum mainnet and Linea
    
    <!-- If applicable, add screenshots and/or recordings to visualize the
    before and after of your change. -->
    
    <img width="416" alt="Screenshot 2024-10-29 at 14 57 00"
    src="https://github.com/user-attachments/assets/a00a61ce-a5be-4398-951d-6479a14c8b7b">
    
    <!-- [screenshots/recordings] -->
    
    <!-- [screenshots/recordings] -->
    <img width="440" alt="Screenshot 2024-10-29 at 14 56 53"
    src="https://github.com/user-attachments/assets/24999468-1c80-4dc4-9bb3-6b68a780f633">
    
    - [x] I’ve followed [MetaMask Contributor
    Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
    Coding
    Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
    - [x] I've completed the PR template to the best of my ability
    - [x] I’ve included tests if applicable
    - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
    if applicable
    - [x] I’ve applied the right labels on the PR (see [labeling
    guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
    Not required for external contributors.
    
    - [ ] I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
    - [ ] I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.
    salimtb committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    9dae0ba View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ca2980b View commit details
    Browse the repository at this point in the history