Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add destruction function to sub manager middleware #10

Merged
merged 4 commits into from
Oct 28, 2019

Conversation

rekmarks
Copy link
Member

@rekmarks rekmarks commented Oct 27, 2019

  • adds destroy function to subscription manager middleware to remove event listener memory leak in the extension background
  • bump patch version to 4.1.1
  • minor touchups (e.g. remove unused variables/parameters)

@rekmarks rekmarks added the bug label Oct 27, 2019
@rekmarks rekmarks requested a review from kumavis October 27, 2019 23:26
Copy link
Member

@kumavis kumavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great. a couple small things:
for subs middleware:
- [ ] throw error if used after destroyed
- [ ] rename destroyMiddleware -> destroySubscriptions

my notes

- destroy fns
  - [ ] subs
    - [x] sub newHeads
    - [x] sub logs
    - [ ] middleware
      - [ ] throw error if used after destroyed?
      - [ ] rename `destroyMiddleware` -> `destroySubscriptions` or just `destroy`
  - [x] filters
    - [x] middleware

@rekmarks rekmarks requested a review from kumavis October 28, 2019 01:04
Copy link
Member

@kumavis kumavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👑

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants