Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an
eth-json-rpc-filters
-related memory leak. Specifically, the subscription manager middleware would not be torn down when a connection was closed, and some listeners would never be removed. That middleware now exposes adestroy
function, which will be called by the extension on connection teardown, here:metamask-extension/app/scripts/metamask-controller.js
Lines 1422 to 1436 in 8dfb0e8
Changes
eth-json-rpc-filters@4.1.1
gaba@1.7.4
(depends oneth-json-rpc-filters
)Result