Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: drop support for Node.js v16, v21 #164

Merged
merged 1 commit into from
Jul 19, 2024
Merged

BREAKING: drop support for Node.js v16, v21 #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-20.04
strategy:
matrix:
node-version: [16.x, 18.x, 20.x]
node-version: [18.x, 20.x]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we avoiding adding 22.x here due to CI fails? https://github.com/MetaMask/eth-json-rpc-middleware/actions/runs/9993141696/job/27619854892?pr=317

Apparently that issue is fixed as of v22.5.1 nodejs/node#53935 (@cryptodev-2s), so it should be safe to add v22 if we can specify a minimum version in this field.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not per se, I also think v22 can be safely added!

Copy link
Contributor Author

@legobeat legobeat Jul 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess pending GitHub runners getting up to date?
https://github.com/MetaMask/eth-json-rpc-filters/actions/runs/10013606103/job/27681585965?pr=179

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"description": "[json-rpc-engine](https://github.com/MetaMask/json-rpc-engine) middleware implementing ethereum filter methods. Backed by an [eth-block-tracker](https://github.com/MetaMask/eth-block-tracker) and web3 provider interface (`web3.currentProvider`).",
"main": "index.js",
"engines": {
"node": "^16.20 || ^18.16 || >=20",
"node": "^18.16 || ^20 || >=22",
"yarn": "^1.22.22"
},
"scripts": {
Expand Down
Loading