Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING: drop support for Node.js v16, v21 #164

Merged
merged 1 commit into from
Jul 19, 2024
Merged

BREAKING: drop support for Node.js v16, v21 #164

merged 1 commit into from
Jul 19, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Jun 11, 2024 •
edited
Loading

This was referenced Jun 11, 2024
Merged
Merged
Merged
@socket-security Socket Security
Copy link

socket-security bot commented Jun 11, 2024 •
edited
Loading

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@legobeat legobeat marked this pull request as ready for review July 16, 2024 23:01
@legobeat legobeat requested a review from a team as a code owner July 16, 2024 23:01
This was referenced Jul 16, 2024
Closed
Merged
Merged
kanthesha
kanthesha approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@kanthesha kanthesha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

MajorLift
MajorLift reviewed Jul 19, 2024
View reviewed changes
.github/workflows/build-test.yml
@@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-20.04
strategy:
matrix:
node-version: [16.x, 18.x, 20.x]
node-version: [18.x, 20.x]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we avoiding adding 22.x here due to CI fails? https://github.com/MetaMask/eth-json-rpc-middleware/actions/runs/9993141696/job/27619854892?pr=317

Apparently that issue is fixed as of v22.5.1 nodejs/node#53935 (@cryptodev-2s), so it should be safe to add v22 if we can specify a minimum version in this field.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not per se, I also think v22 can be safely added!

Copy link
Contributor Author

@legobeat legobeat Jul 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess pending GitHub runners getting up to date?
https://github.com/MetaMask/eth-json-rpc-filters/actions/runs/10013606103/job/27681585965?pr=179

@legobeat legobeat merged commit 26dab47 into MetaMask:main Jul 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MajorLift MajorLift MajorLift left review comments

@kanthesha kanthesha kanthesha approved these changes

@cryptodev-2s cryptodev-2s Awaiting requested review from cryptodev-2s

Assignees
No one assigned
Labels
None yet
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@legobeat @MajorLift @kanthesha