Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: @metamask/eth-block-tracker@^9.0.3->^10.0.0 #176

Merged
merged 5 commits into from
Jul 22, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Jul 17, 2024

  • deps: @metamask/eth-json-rpc-middleware@^12.0.0->^13.0.0
  • deps: @metamask/eth-block-tracker@^9.0.3->^10.1.0^10.0.0
    • 10.1.0 causes a regression here, so holding back at 10.0.0.

Blocked by

Blocking

Copy link

socket-security bot commented Jul 19, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@legobeat
Copy link
Contributor Author

@SocketSecurity ignore npm/@metamask/eth-block-tracker@10.1.0

new author ok

@legobeat legobeat requested a review from kanthesha July 19, 2024 20:13
@legobeat legobeat changed the title deps: @metamask/eth-block-tracker@^9.0.3->^10.0.0 deps: @metamask/eth-block-tracker@^9.0.3->^10.1.0 Jul 19, 2024
@legobeat legobeat force-pushed the eth-json-rpc-middleware-13 branch from 5b2e830 to 22d6735 Compare July 20, 2024 04:32
@legobeat
Copy link
Contributor Author

@kanthesha @cryptodev-2s : Upgrading from @metamask/eth-block-tracker 10.0.0 to 10.1.0 is causing a regression: https://github.com/MetaMask/eth-json-rpc-filters/actions/runs/10013679322/job/27681824164?pr=176

# LogFilter - basic
Error: PollingBlockTracker - encountered an error while attempting to update latest block:
TypeError: this._provider.request is not a function
    at PollingBlockTracker._fetchLatestBlock (/home/runner/work/eth-json-rpc-filters/eth-json-rpc-filters/node_modules/@metamask/eth-block-tracker/src/PollingBlockTracker.ts:275:43)
    at PollingBlockTracker._updateLatestBlock (/home/runner/work/eth-json-rpc-filters/eth-json-rpc-filters/node_modules/@metamask/eth-block-tracker/src/PollingBlockTracker.ts:258:36)
    at PollingBlockTracker._updateAndQueue (/home/runner/work/eth-json-rpc-filters/eth-json-rpc-filters/node_modules/@metamask/eth-block-tracker/src/PollingBlockTracker.ts:292:18)
    at PollingBlockTracker._start (/home/runner/work/eth-json-rpc-filters/eth-json-rpc-filters/node_modules/@metamask/eth-block-tracker/src/PollingBlockTracker.ts:249:10)
    at PollingBlockTracker._maybeStart (/home/runner/work/eth-json-rpc-filters/eth-json-rpc-filters/node_modules/@metamask/eth-block-tracker/src/PollingBlockTracker.ts:166:10)
    at PollingBlockTracker._onNewListener (/home/runner/work/eth-json-rpc-filters/eth-json-rpc-filters/node_modules/@metamask/eth-block-tracker/src/PollingBlockTracker.ts:146:12)
    at safeApply (/home/runner/work/eth-json-rpc-filters/eth-json-rpc-filters/node_modules/@metamask/safe-event-emitter/index.ts:10:13)
    at PollingBlockTracker.emit (/home/runner/work/eth-json-rpc-filters/eth-json-rpc-filters/node_modules/@metamask/safe-event-emitter/index.ts:63:7)
    at _addListener (node:events:560:14)
    at PollingBlockTracker.addListener (node:events:609:10)
    at PollingBlockTracker.once (node:events:653:8)
    at /home/runner/work/eth-json-rpc-filters/eth-json-rpc-filters/test/util.js:50:50
    at new Promise (<anonymous>)
    at Object.trackNextBlock (/home/runner/work/eth-json-rpc-filters/eth-json-rpc-filters/test/util.js:50:12)
    at deployLogEchoContract (/home/runner/work/eth-json-rpc-filters/eth-json-rpc-filters/test/util.js:149:15)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at PollingBlockTracker._updateAndQueue (/home/runner/work/eth-json-rpc-filters/eth-json-rpc-filters/node_modules/@metamask/eth-block-tracker/src/PollingBlockTracker.ts:294:22)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
Error: PollingBlockTracker - encountered an error while attempting to update latest block:
  • Reverting this to ~10.0.0 but indicating tentative support for 10.1.1+ (this assumes that the next release of @metamask/eth-block-tracker will fix the issue)

@legobeat legobeat changed the title deps: @metamask/eth-block-tracker@^9.0.3->^10.1.0 deps: @metamask/eth-block-tracker@^9.0.3->^10.0.0 Jul 20, 2024
@legobeat legobeat marked this pull request as ready for review July 20, 2024 04:41
@legobeat legobeat requested a review from a team as a code owner July 20, 2024 04:41
Copy link
Contributor

@kanthesha kanthesha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@legobeat legobeat merged commit 2dc0d45 into MetaMask:main Jul 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants