Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nodejs v14 compatibility #86

Merged
merged 2 commits into from
Dec 12, 2022
Merged

Fix nodejs v14 compatibility #86

merged 2 commits into from
Dec 12, 2022

Conversation

legobeat
Copy link
Contributor

Minimum changes to make tests pass on both nodejs v12 and v14

@socket-security
Copy link

socket-security bot commented Dec 12, 2022

Socket Security Pull Request Report

👍 No new dependency issues detected in pull request

Pull request report summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@2.4.2

Ignoring: keccak@3.0.2, secp256k1@4.0.3

Powered by socket.dev

@legobeat legobeat marked this pull request as ready for review December 12, 2022 11:12
@legobeat legobeat requested a review from a team as a code owner December 12, 2022 11:12
@legobeat legobeat requested a review from mcmire December 12, 2022 11:12
@legobeat
Copy link
Contributor Author

@SocketSecurity ignore keccak@3.0.2 secp256k1@4.0.3

@@ -37,7 +37,7 @@
],
"dependencies": {
"deep-equal": "^1.1.0",
"eth-block-tracker": "^4.4.2",
"eth-block-tracker": "^5.0.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why this update was needed? I would have expected v4 of eth-block-tracker to work on v14.

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@legobeat legobeat merged commit 16c0a80 into MetaMask:main Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants