-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nodejs v14 compatibility #86
Conversation
Socket Security Pull Request Report👍 No new dependency issues detected in pull request Pull request report summary
Bot CommandsTo ignore an alert, reply with a comment starting with Ignoring: Powered by socket.dev |
@SocketSecurity ignore keccak@3.0.2 secp256k1@4.0.3 |
@@ -37,7 +37,7 @@ | |||
], | |||
"dependencies": { | |||
"deep-equal": "^1.1.0", | |||
"eth-block-tracker": "^4.4.2", | |||
"eth-block-tracker": "^5.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea why this update was needed? I would have expected v4 of eth-block-tracker to work on v14.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Minimum changes to make tests pass on both nodejs v12 and v14