Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metamask freezes when trying to confirm transaction on Trezor T #12967

Closed
Fefiox opened this issue Dec 3, 2021 · 43 comments · May be fixed by MetaMask/eth-trezor-keyring#155
Closed

Metamask freezes when trying to confirm transaction on Trezor T #12967

Fefiox opened this issue Dec 3, 2021 · 43 comments · May be fixed by MetaMask/eth-trezor-keyring#155
Labels

Comments

@Fefiox
Copy link

Fefiox commented Dec 3, 2021

When trying to confirm the transaction after giving access to metamask to my trezor T wallet, it freezes and doesn´t continue, freezing also the browser.

Steps to reproduce (REQUIRED)
Steps to reproduce the behavior, libraries used with version number, and/or any setup information to easily reproduce:

  1. Make a transaction
  2. Opens a new page where metamask asks for permission to confirm the transaction on the Trezor T
  3. Give access
  4. When the page closes and the transaction should appear to confirm on the Trezor, nothing happens and the app freezes.

Expected behavior
Confirm the transaction on the Trezor T.

Browser details (please complete the following information):

  • OS: Windows
  • Hardware Wallet: Trezor Firmware version 2.4.2
  • Browser: Firefox
  • MetaMask Version:10.6.4
@danjm
Copy link
Contributor

danjm commented Dec 3, 2021

Thanks for the report. Was this on the ethereum mainnet network?

@Fefiox
Copy link
Author

Fefiox commented Dec 4, 2021

It was on Avalanche mainnet, but it happens in all of them.

@prusnak
Copy link

prusnak commented Dec 4, 2021

This is most probably a duplicate of #12130

@Sukha5911
Copy link

U uthe

@Einoow
Copy link

Einoow commented Dec 9, 2021

Same problem, waiting for fix.

@Einoow
Copy link

Einoow commented Dec 21, 2021

Hey! Any update about this problem?

Browser details (please complete the following information):

OS: Windows
Hardware Wallet: Trezor model one Firmware version 1.10.3
Browser: Firefox
MetaMask Version:10.8.0

@prusnak
Copy link

prusnak commented Dec 21, 2021

Hardware Wallet: Trezor model one Firmware version 1.10.3

@Einoow the issue has been fixed in Metamask 10.8.0 but you need to update your firmware to version 1.10.4

@Einoow
Copy link

Einoow commented Jan 3, 2022

Hey! Thanks for your response, I have made some tests and seems like the problem is still there for me.

OS: Windows
Hardware Wallet: Trezor model one Firmware version 1.10.4
Browser: Firefox
MetaMask Version: 10.8.1

@bitblock-01
Copy link

Same problem. Anyone know how to fix it?

@Einoow
Copy link

Einoow commented Jan 22, 2022

Same problem. Anyone know how to fix it?

Still waiting, hope they fix it in the next update

@Zenitsu227
Copy link

Zenitsu227 commented Jan 25, 2022

Experiencing the same issue

Browser details (please complete the following information):
OS: Windows
Hardware Wallet: Trezor model one Firmware version 1.10.5
Browser: Firefox
MetaMask Version: 10.8.1

@Smileez1234
Copy link

same problem as above...also had this problem a few weeks back and tried reinstalling firmware on trezor multiple times and it just started working. cant confirm that firmware was the problem as I tried this multiple times before having any success. this problem just started again last night. has anyone found a solution?

@Smileez1234
Copy link

I also tried restoring the wallet from a new device (metamask no problem) but when importing the hardware wallet from metamask, it brings up a list of wallets to import, none of which is the address I am looking for.

@ryny24
Copy link

ryny24 commented Feb 8, 2022

This issue is so annoying. Happens almost every day. Is this being resolved?

@Einoow
Copy link

Einoow commented Feb 11, 2022

I have checked the new update and it is still happening to me

@PabloCastellano
Copy link

Still happening to me in 10.9.2

@Relic180
Copy link

Relic180 commented Feb 15, 2022

Also having the issue.

OS: Windows
Hardware Wallet: Trezor model T Firmware version 2.4.3
Browser: Chrome
MetaMask Version: 10.9.2

Is there anything else helpful people could provide to help fix this issue? A way to collect logs or something that we could attach here? I found the "download state logs" option under settings > advanced, but I can't get to it or activate it once I've gone through the steps that cause it lock up.

It doesn't appear to happen for every site or every action, but it does seem to be repeatable 100% of the time for certain sites and certain actions.

Current steps I use to reproduce:

  1. Navigate to kogefarm.io/vaults
  2. Connect MetaMask to the site (Polygon).
  3. Attempt to approve the Kogecoin vault.
  4. Sometimes it freezes at this point when clicking "approve".
  5. Otherwise, the Trezor window pops up to request passphrase, after which it freezes.

Currently I have both a standard hot wallet, and my Trezor-linked walled in MetaMask. Hot wallet seems to have no problems.

EDIT: Looks like I was able to get it to lock up simply by trying to send Matic from my HW to Hot wallet within MM.

@AlexJupiter AlexJupiter added type-bug area-hardware hardware-trezor browser-firefox Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. and removed needs-reproduction labels Feb 17, 2022
@AlexJupiter
Copy link
Contributor

Thanks for your comments. @bitblock, @Smileez1234, @ryny24, @PabloCastellano are you also using Windows OS here? I'm trying to figure out the commonalities.

@PabloCastellano
Copy link

@AlexJupiter Nope, I'm using Linux Mint. Not sure if it's a commonality but when I have hit this issue I was using the Polygon network, and it worked for other networks intead.

@PabloCastellano
Copy link

PabloCastellano commented Feb 19, 2022

In my case I cannot get to swap on Polygon. I've tried with different RPCs but no luck.

@AlexJupiter Could you try the following use cases? This is what I'm seeing:

In uniswap (https://app.uniswap.org/#/swap?chain=polygon), the prices keeps updating all the time and I cannot click "Confirm" to initiate the swap tx.

In 1inch (https://app.1inch.io/#/137/swap/USDT/MATIC): when I want to approve the smart contract for the token I want to trade, a metamask popup appears and I click to confirm signing the transaction, but metamask (and firefox at some sort) freezes.

@Relic180
Copy link

Are there any details on this? Is it something that is actually going to get fixed?

I just recently added my Trezor T to Metamask and turns out that probably +80% of the actions I try to take are locking up the wallet, INCLUDING sending funds that I transferred from my hotwallet, back to my hotwallet in an attempt to just get unblocked.

Recently tried to execute a swap on bogged.finance, and after who knows how long (only noticed it the next day), the transaction failed with the message "Transaction decoding is not available for chainId 56" in the MM transaction data.

@digiwand digiwand removed their assignment Apr 14, 2022
@hilvmason hilvmason assigned hilvmason and darkwing and unassigned hilvmason Apr 19, 2022
@EarthSalamander42
Copy link

Having same issue on ETH main network, moved my funds from MM address to Trezor imported into MM for extra safety, now i can't move them anymore, same freeze than everyone else here. Also tried importing MM + trezor to another browser but i can't find the same ETH adresses that i have my funds into. This is kinda scary, i'm wondering what will happen to my funds if my windows crash or my HDD dies in the meantime of a fix being found...

@EarthSalamander42
Copy link

Looks like when i've imported Trezor wallets, the addresses are not the right ones. Because if i import it in 2 new browsers i have the same addresses in both, but the ones initially imported into Brave where my funds are locked are different. Could that be it?

@seaona
Copy link
Contributor

seaona commented May 4, 2022

Here is the complete explanation of what is happening.

What is causing the issue:
The problem is caused due to mixing Trezor addresses that are being imported with a different passphrase.
Basically, when you import Trezor addresses you are asked to provide a passphrase (see screen below). This passhprase dictates the addresses that are being displayed and can be imported.
In the case you import Trezor addresses with one passphrase, lock Metamask and then import Trezor addresses with another passphrase, the first ones will be un-usable and Metamask will freeze in the loop indicated on the comment above.

image

Reproduction steps:

  1. Import a couple of Trezor addresses with a keyphrase. I.e. "123"
  2. Lock Metamask
  3. Unlock Metamask -- Trezor addresses should be there
  4. Import a couple of Trezor addresses - now using a different keyphrase. I.e. "456"
  5. Now try to use one address from step 1 - Metamask will freeze
trezor-freezing.mp4

How to solve the issue (temporary)
First of all, you must identify which is the passphrase that you want to use (with the derived addresses). Review which are the passphrases that you have used in the past (it will be more than one if you are encountering this issue).

Once you know it, you can simply remove Metamask and install it again, and import Trezor addresses using that specific passphrase.
In the case you want to use addresses from a different passphrase I would recommend to use another Metamask instance in another browser and use the other passphrase, but never mix them.

A fix will be develop soon, so this situation does not happen.

@Tantos1
Copy link

Tantos1 commented Jul 13, 2022

I didnt use a passphrase and when I try on another PC without the passphrase Im still unable to derive the address that I need

@sime
Copy link
Contributor

sime commented Jul 13, 2022

@Tantos1 since you are not using a passphrase, could you try and disable passphrase in Trezor Suite settings and go through the same steps again.

I wonder if having passphrase enabled is apart of the problem.

@Tantos1
Copy link

Tantos1 commented Jul 14, 2022

I tried that as well it also did not work

@aliceturino
Copy link

Is there any prediction in solving this issue? I can't use this temporary solution and my money is stuck.

@yuki-js
Copy link

yuki-js commented Aug 7, 2022

I also found the root cause and finally discovered this issue.

To avoid freeze, make sure that your address is exactly same as the one Trezor Suite shows, and never type incorrect passphrase when unlocking Trezor (leave it blank if you don't have passphrase) . If you have different wallets with different passphrase, please unplug it.
When you got into freeze, wait for 1000-times-of-heavy-computation, or terminate JS thread. Some browser such as Firefox need force restart.

@kevinghim kevinghim added Sev2-normal Normal severity; minor loss of service or inconvenience. and removed Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. labels Apr 21, 2023
@onkaraman
Copy link

onkaraman commented Jun 6, 2023

Is this issue resolved? I am currently experiencing something very similar.

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

@github-actions github-actions bot added the stale issues and PRs marked as stale label Sep 12, 2023
@github-actions
Copy link
Contributor

This issue was closed because there has been no follow up activity in the last 45 days. If you feel this was closed in error, please reopen and provide evidence on the latest release of the extension. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.