Skip to content

Commit

Permalink
Fix SimpleDropdown event bubbling (#7627)
Browse files Browse the repository at this point in the history
  • Loading branch information
whymarrh authored Dec 3, 2019
1 parent b8e3957 commit 4ec92ce
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion ui/app/components/app/dropdowns/simple-dropdown.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@ class SimpleDropdown extends Component {
'simple-dropdown__option--selected': option.value === selectedOption,
})}
key={option.value}
onClick={() => {
onClick={(event) => {
event.stopPropagation()
if (option.value !== selectedOption) {
onSelect(option.value)
}
Expand Down

0 comments on commit 4ec92ce

Please sign in to comment.