Fix SimpleDropdown close event #7627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whymarrh
force-pushed
the
fix-dropdowns
branch
from
fb83879 to
15dd834
Compare
I'm not sure I follow - how would that result in Edit: Oh wait, it looks like Edit2: Yes, that is indeed the case. |
Gudahtt
previously approved these changes
Dec 3, 2019
whymarrh
force-pushed
the
fix-dropdowns
branch
from
15dd834 to
23ad1a2
Compare
Updated |
rickycodes
approved these changes
Dec 3, 2019
Gudahtt
added a commit
that referenced
this pull request
Dec 3, 2019
* origin/develop: Fix SimpleDropdown event bubbling (#7627) Remove unneeded store connections (#7625) Replace wild random number key with index (#7629) Use ES6 exports for selectors (#7626) Fix a typo made comparing previous prop (#7628) Connect distinct accounts per site (#7004) eslint: Enable more react/jsx-* rules (#7592) Enable react/no-unused-state rule for ESLint (#7609) Enable no-var rule for ESLint (#7590) Process URL fragment for ens-ipfs redirects (#7604) add locale fix script (#7580) Prevent redux state mutation (#7598)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #7540
This PR fixes a bug that has surfaced post-#7540, where the dropdown wouldn't close after a selection.
The call to
this.handleClose()in the onClick handler would set the state to false which would result intoggleOpen, called in theonClickhandler on the parentdiv, readingfalsefromprevState. This wasn't an issue before as the reference to state was stale/read before the setState call.The fix here stops the propagation of the click event to the parent.