Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert SimpleDropdown component to use JSX #7540

Merged
merged 1 commit into from
Nov 24, 2019

Conversation

whymarrh
Copy link
Contributor

Refs #6291

This PR replaces the hyperscript in the SimpleDropdown with JSX.

const { isOpen } = this.state
this.setState({ isOpen: !isOpen })
this.setState((prevState) => ({
isOpen: prevState.isOpen,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a ! missing here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is a good catch

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@whymarrh whymarrh merged commit 1cac6f2 into MetaMask:develop Nov 24, 2019
@whymarrh whymarrh deleted the hyperscript-29 branch November 24, 2019 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants