Skip to content

Commit 6a30757

Browse files
feat: cp-13.3.1 bump solana snap to 2.3.10 (#36129)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This PR bumps the Solana snap to version `2.3.10`. ## **Changelog** CHANGELOG entry: Added a mechanism on the Solana snap to time out websocket subscriptions ([#525](MetaMask/snap-solana-wallet#525)) CHANGELOG entry: Offloaded the assets and transactions sync from account creation on the Solana snap ([#528](MetaMask/snap-solana-wallet#528)) CHANGELOG entry: Enforced proper assets state sync between the Solana snap and the client ([#529](MetaMask/snap-solana-wallet#529)) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
1 parent a9e859d commit 6a30757

File tree

3 files changed

+17
-12
lines changed

3 files changed

+17
-12
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -352,7 +352,7 @@
352352
"@metamask/snaps-rpc-methods": "^13.5.1",
353353
"@metamask/snaps-sdk": "^9.3.0",
354354
"@metamask/snaps-utils": "^11.5.0",
355-
"@metamask/solana-wallet-snap": "^2.3.8",
355+
"@metamask/solana-wallet-snap": "^2.3.10",
356356
"@metamask/solana-wallet-standard": "^0.5.1",
357357
"@metamask/streams": "^0.4.0",
358358
"@metamask/subscription-controller": "^0.1.0",

test/e2e/tests/metrics/delete-metametrics-data.spec.ts

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,17 @@
11
import { strict as assert } from 'assert';
2-
import { MockedEndpoint, Mockttp } from 'mockttp';
32
import { Suite } from 'mocha';
4-
import { getEventPayloads, withFixtures } from '../../helpers';
5-
import FixtureBuilder from '../../fixture-builder';
6-
import { Driver } from '../../webdriver/driver';
7-
import { TestSuiteArguments } from '../confirmations/transactions/shared';
3+
import { MockedEndpoint, Mockttp } from 'mockttp';
84
import { MOCK_META_METRICS_ID } from '../../constants';
5+
import FixtureBuilder from '../../fixture-builder';
6+
import { getEventPayloads, withFixtures } from '../../helpers';
7+
import { loginWithBalanceValidation } from '../../page-objects/flows/login.flow';
98
import HeaderNavbar from '../../page-objects/pages/header-navbar';
109
import HomePage from '../../page-objects/pages/home/homepage';
1110
import PrivacySettings from '../../page-objects/pages/settings/privacy-settings';
1211
import SettingsPage from '../../page-objects/pages/settings/settings-page';
13-
import { loginWithBalanceValidation } from '../../page-objects/flows/login.flow';
12+
import { Driver } from '../../webdriver/driver';
13+
import { TestSuiteArguments } from '../confirmations/transactions/shared';
14+
import { DEFAULT_SOLANA_WS_MOCKS } from '../solana/mocks/websocketDefaultMocks';
1415

1516
/**
1617
* mocks the segment api multiple times for specific payloads that we expect to
@@ -84,6 +85,10 @@ describe('Delete MetaMetrics Data', function (this: Suite) {
8485
})
8586
.build(),
8687
title: this.test?.fullTitle(),
88+
withSolanaWebSocket: {
89+
server: true,
90+
mocks: DEFAULT_SOLANA_WS_MOCKS,
91+
},
8792
testSpecificMock: mockSegment,
8893
},
8994
async ({

yarn.lock

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7449,10 +7449,10 @@ __metadata:
74497449
languageName: node
74507450
linkType: hard
74517451

7452-
"@metamask/solana-wallet-snap@npm:^2.3.8":
7453-
version: 2.3.8
7454-
resolution: "@metamask/solana-wallet-snap@npm:2.3.8"
7455-
checksum: 10/e1fa80026a78ccf853c5bdf8493e47ea2edaba6d39e715f2f54030c605271ee238fd15a832b2d876365fdb62d66d35053c5952a39a66c6ae97d5e03ee0a22bf8
7452+
"@metamask/solana-wallet-snap@npm:^2.3.10":
7453+
version: 2.3.10
7454+
resolution: "@metamask/solana-wallet-snap@npm:2.3.10"
7455+
checksum: 10/06d00d86c2e87c430fd59fd8a28de9bcc50156650dcb2f202b6822beaba458d2fc30ba68c9425010829d4e7763884444cc7f01eb6da047add8d0a42408073ec0
74567456
languageName: node
74577457
linkType: hard
74587458

@@ -31884,7 +31884,7 @@ __metadata:
3188431884
"@metamask/snaps-rpc-methods": "npm:^13.5.1"
3188531885
"@metamask/snaps-sdk": "npm:^9.3.0"
3188631886
"@metamask/snaps-utils": "npm:^11.5.0"
31887-
"@metamask/solana-wallet-snap": "npm:^2.3.8"
31887+
"@metamask/solana-wallet-snap": "npm:^2.3.10"
3188831888
"@metamask/solana-wallet-standard": "npm:^0.5.1"
3188931889
"@metamask/streams": "npm:^0.4.0"
3189031890
"@metamask/subscription-controller": "npm:^0.1.0"

0 commit comments

Comments
 (0)