Skip to content

Nwnt 409 add a mechanism to time out websocket subscriptions #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 16, 2025
Merged

Nwnt 409 add a mechanism to time out websocket subscriptions #525

merged 5 commits into from
Sep 16, 2025

Conversation

@xavier-brochard
Copy link
Contributor

@xavier-brochard xavier-brochard commented Sep 15, 2025 •
edited
Loading

Add WebSocket Subscription Timeout Mechanism

Problem

Some dApps (like jup.ag) request signature monitoring but broadcast transactions themselves. If the broadcast doesn't occur, the snap accumulates stale subscriptions waiting for notifications that will never arrive, causing memory leaks and performance issues.

Solution

Added a timeout mechanism that automatically cleans up expired subscriptions when the client becomes inactive.

Key Changes

  • Expiry Support: Added optional expiryMilliseconds to SubscriptionRequest and expiresAt timestamp to PendingSubscription
  • Auto-cleanup: SubscriptionService now listens for onInactive events and removes expired subscriptions
  • Default Timeout: Signature subscriptions expire after 10 minutes (sufficient for Solana transaction confirmation)
  • Error Handling: Uses Promise.allSettled() to ensure cleanup continues even if individual unsubscriptions fail
  • Backward compatible (existing subscriptions without expiry remain permanent)

cursor[bot]

This comment was marked as outdated.

Sign in to view

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 16, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
95.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

aganglada
aganglada approved these changes Sep 16, 2025
View reviewed changes
Copy link
Contributor

@aganglada aganglada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG

@xavier-brochard xavier-brochard merged commit 277ab7f into main Sep 16, 2025
10 checks passed
@xavier-brochard xavier-brochard deleted the NWNT-409-add-a-mechanism-to-time-out-websocket-subscriptions branch September 16, 2025 09:48
This was referenced Sep 19, 2025
Merged
Merged
github-merge-queue bot pushed a commit to MetaMask/metamask-mobile that referenced this pull request Sep 19, 2025
@xavier-brochard
feat: cp-7.55.0 bump solana snap to 2.3.10 (#20046)
e09f750 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This PR bumps the Solana snap to version `2.3.10`.

## **Changelog**

CHANGELOG entry: Added a mechanism on the Solana snap to time out
websocket subscriptions
([#525](MetaMask/snap-solana-wallet#525))
CHANGELOG entry: Offloaded the assets and transactions sync from account
creation on the Solana snap
([#528](MetaMask/snap-solana-wallet#528))
CHANGELOG entry: Enforced proper assets state sync between the Solana
snap and the client
([#529](MetaMask/snap-solana-wallet#529))

## **Related issues**

Fixes:

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
runway-github bot added a commit to MetaMask/metamask-mobile that referenced this pull request Sep 19, 2025
@runway-github
temp+feat: cp-7.55.0 bump solana snap to 2.3.10 (#20046)
bc27579 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This PR bumps the Solana snap to version `2.3.10`.

## **Changelog**

CHANGELOG entry: Added a mechanism on the Solana snap to time out
websocket subscriptions
([#525](MetaMask/snap-solana-wallet#525))
CHANGELOG entry: Offloaded the assets and transactions sync from account
creation on the Solana snap
([#528](MetaMask/snap-solana-wallet#528))
CHANGELOG entry: Enforced proper assets state sync between the Solana
snap and the client
([#529](MetaMask/snap-solana-wallet#529))

## **Related issues**

Fixes:

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
aganglada pushed a commit to MetaMask/metamask-mobile that referenced this pull request Sep 19, 2025
@xavier-brochard @aganglada
feat: cp-7.55.0 bump solana snap to 2.3.10 (#20046)
507818a 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

This PR bumps the Solana snap to version `2.3.10`.

CHANGELOG entry: Added a mechanism on the Solana snap to time out
websocket subscriptions
([#525](MetaMask/snap-solana-wallet#525))
CHANGELOG entry: Offloaded the assets and transactions sync from account
creation on the Solana snap
([#528](MetaMask/snap-solana-wallet#528))
CHANGELOG entry: Enforced proper assets state sync between the Solana
snap and the client
([#529](MetaMask/snap-solana-wallet#529))

Fixes:

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

<!-- [screenshots/recordings] -->

<!-- [screenshots/recordings] -->

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@runway-github runway-github bot mentioned this pull request Sep 19, 2025
Merged
7 tasks
weitingsun added a commit to MetaMask/metamask-mobile that referenced this pull request Sep 19, 2025
@weitingsun
chore(runway): cherry-pick feat: bump solana snap to 2.3.10 (#20059)
d678bfb 
- feat: cp-7.55.0 bump solana snap to 2.3.10 (#20046)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This PR bumps the Solana snap to version `2.3.10`.

## **Changelog**

CHANGELOG entry: Added a mechanism on the Solana snap to time out
websocket subscriptions
([#525](MetaMask/snap-solana-wallet#525))
CHANGELOG entry: Offloaded the assets and transactions sync from account
creation on the Solana snap
([#528](MetaMask/snap-solana-wallet#528))
CHANGELOG entry: Enforced proper assets state sync between the Solana
snap and the client
([#529](MetaMask/snap-solana-wallet#529))

## **Related issues**

Fixes:

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding

Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling

guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
[e09f750](e09f750)
github-merge-queue bot pushed a commit to MetaMask/metamask-extension that referenced this pull request Sep 22, 2025
@xavier-brochard
feat: cp-13.3.1 bump solana snap to 2.3.10 (#36129)
fc0dcab 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This PR bumps the Solana snap to version `2.3.10`.

## **Changelog**

CHANGELOG entry: Added a mechanism on the Solana snap to time out
websocket subscriptions
([#525](MetaMask/snap-solana-wallet#525))
CHANGELOG entry: Offloaded the assets and transactions sync from account
creation on the Solana snap
([#528](MetaMask/snap-solana-wallet#528))
CHANGELOG entry: Enforced proper assets state sync between the Solana
snap and the client
([#529](MetaMask/snap-solana-wallet#529))

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
github-merge-queue bot pushed a commit to MetaMask/metamask-extension that referenced this pull request Sep 22, 2025
@xavier-brochard
feat: cp-13.3.1 bump solana snap to 2.3.10 (#36129)
7336cc3 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This PR bumps the Solana snap to version `2.3.10`.

## **Changelog**

CHANGELOG entry: Added a mechanism on the Solana snap to time out
websocket subscriptions
([#525](MetaMask/snap-solana-wallet#525))
CHANGELOG entry: Offloaded the assets and transactions sync from account
creation on the Solana snap
([#528](MetaMask/snap-solana-wallet#528))
CHANGELOG entry: Enforced proper assets state sync between the Solana
snap and the client
([#529](MetaMask/snap-solana-wallet#529))

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
github-merge-queue bot pushed a commit to MetaMask/metamask-extension that referenced this pull request Sep 22, 2025
@xavier-brochard
feat: cp-13.3.1 bump solana snap to 2.3.10 (#36129)
6a30757 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This PR bumps the Solana snap to version `2.3.10`.

## **Changelog**

CHANGELOG entry: Added a mechanism on the Solana snap to time out
websocket subscriptions
([#525](MetaMask/snap-solana-wallet#525))
CHANGELOG entry: Offloaded the assets and transactions sync from account
creation on the Solana snap
([#528](MetaMask/snap-solana-wallet#528))
CHANGELOG entry: Enforced proper assets state sync between the Solana
snap and the client
([#529](MetaMask/snap-solana-wallet#529))

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
runway-github bot added a commit to MetaMask/metamask-extension that referenced this pull request Sep 22, 2025
@runway-github
temp+feat: cp-13.3.1 bump solana snap to 2.3.10 (#36129)
3c47a7c 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This PR bumps the Solana snap to version `2.3.10`.

## **Changelog**

CHANGELOG entry: Added a mechanism on the Solana snap to time out
websocket subscriptions
([#525](MetaMask/snap-solana-wallet#525))
CHANGELOG entry: Offloaded the assets and transactions sync from account
creation on the Solana snap
([#528](MetaMask/snap-solana-wallet#528))
CHANGELOG entry: Enforced proper assets state sync between the Solana
snap and the client
([#529](MetaMask/snap-solana-wallet#529))

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
runway-github bot added a commit to MetaMask/metamask-extension that referenced this pull request Sep 22, 2025
@runway-github
temp+feat: cp-13.3.1 bump solana snap to 2.3.10 (#36129)
7e346d8 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This PR bumps the Solana snap to version `2.3.10`.

## **Changelog**

CHANGELOG entry: Added a mechanism on the Solana snap to time out
websocket subscriptions
([#525](MetaMask/snap-solana-wallet#525))
CHANGELOG entry: Offloaded the assets and transactions sync from account
creation on the Solana snap
([#528](MetaMask/snap-solana-wallet#528))
CHANGELOG entry: Enforced proper assets state sync between the Solana
snap and the client
([#529](MetaMask/snap-solana-wallet#529))

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
gauthierpetetin pushed a commit to MetaMask/metamask-extension that referenced this pull request Sep 22, 2025
@xavier-brochard @gauthierpetetin
feat: cp-13.3.1 bump solana snap to 2.3.10 (#36129)
9d1efbf 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

This PR bumps the Solana snap to version `2.3.10`.

CHANGELOG entry: Added a mechanism on the Solana snap to time out
websocket subscriptions
([#525](MetaMask/snap-solana-wallet#525))
CHANGELOG entry: Offloaded the assets and transactions sync from account
creation on the Solana snap
([#528](MetaMask/snap-solana-wallet#528))
CHANGELOG entry: Enforced proper assets state sync between the Solana
snap and the client
([#529](MetaMask/snap-solana-wallet#529))

Fixes:

1. Go to this page...
2.
3.

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

<!-- [screenshots/recordings] -->

<!-- [screenshots/recordings] -->

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@runway-github runway-github bot mentioned this pull request Sep 22, 2025
Merged
7 tasks
gauthierpetetin added a commit to MetaMask/metamask-extension that referenced this pull request Sep 23, 2025
@runway-github @xavier-brochard
@metamaskbot @gauthierpetetin @seaona
release(runway): cherry-pick feat: bump solana snap to 2.3.10 (#36179)
1db247d 
- feat: cp-13.3.1 bump solana snap to 2.3.10 (#36129)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This PR bumps the Solana snap to version `2.3.10`.

## **Changelog**

CHANGELOG entry: Added a mechanism on the Solana snap to time out
websocket subscriptions
([#525](MetaMask/snap-solana-wallet#525))
CHANGELOG entry: Offloaded the assets and transactions sync from account
creation on the Solana snap
([#528](MetaMask/snap-solana-wallet#528))
CHANGELOG entry: Enforced proper assets state sync between the Solana
snap and the client
([#529](MetaMask/snap-solana-wallet#529))

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding

Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling

guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
[6a30757](6a30757)

---------

Co-authored-by: Xavier Brochard <xavier.alexandre.brochard@gmail.com>
Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
Co-authored-by: Gauthier Petetin <gauthierpetetin@hotmail.com>
Co-authored-by: Xavier Brochard <xavier.brochard@consensys.net>
Co-authored-by: seaona <54408225+seaona@users.noreply.github.com>
weitingsun pushed a commit to MetaMask/metamask-mobile that referenced this pull request Oct 15, 2025
@xavier-brochard @weitingsun
feat: cp-7.55.0 bump solana snap to 2.3.10 (#20046)
df9253b 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This PR bumps the Solana snap to version `2.3.10`.

## **Changelog**

CHANGELOG entry: Added a mechanism on the Solana snap to time out
websocket subscriptions
([#525](MetaMask/snap-solana-wallet#525))
CHANGELOG entry: Offloaded the assets and transactions sync from account
creation on the Solana snap
([#528](MetaMask/snap-solana-wallet#528))
CHANGELOG entry: Enforced proper assets state sync between the Solana
snap and the client
([#529](MetaMask/snap-solana-wallet#529))

## **Related issues**

Fixes:

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@aganglada aganglada aganglada approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xavier-brochard @aganglada