Skip to content

Conversation

@xavier-brochard
Copy link
Contributor

@xavier-brochard xavier-brochard commented Sep 19, 2025

Description

This PR bumps the Solana snap to version 2.3.10.

Changelog

CHANGELOG entry: Added a mechanism on the Solana snap to time out websocket subscriptions (#525)
CHANGELOG entry: Offloaded the assets and transactions sync from account creation on the Solana snap (#528)
CHANGELOG entry: Enforced proper assets state sync between the Solana snap and the client (#529)

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@xavier-brochard xavier-brochard added the No QA Needed Apply this label when your PR does not need any QA effort. label Sep 19, 2025
@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​solana-wallet-snap@​2.3.8 ⏵ 2.3.10100 +110088 +198 -1100

View full report

@aganglada aganglada added the run-ios-e2e-smoke Trigger iOS E2E tests on BitRise label Sep 19, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f8f378f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/440dc6e1-26f7-419f-a159-c1bee8dbe105

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the run-ios-e2e-smoke label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sonarqubecloud
Copy link

@aganglada aganglada added No E2E Smoke Needed and removed run-ios-e2e-smoke Trigger iOS E2E tests on BitRise labels Sep 19, 2025
@xavier-brochard xavier-brochard added this pull request to the merge queue Sep 19, 2025
auto-merge was automatically disabled September 19, 2025 16:07

Pull Request is not mergeable

auto-merge was automatically disabled September 19, 2025 16:07

Pull Request is not mergeable

Merged via the queue into main with commit e09f750 Sep 19, 2025
150 of 154 checks passed
@xavier-brochard xavier-brochard deleted the bump-solana-snap-2.3.10 branch September 19, 2025 16:16
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2025
@metamaskbot metamaskbot added release-7.57.0 Issue or pull request that will be included in release 7.57.0 release-7.55.0 Issue or pull request that will be included in release 7.55.0 and removed release-7.57.0 Issue or pull request that will be included in release 7.57.0 labels Sep 19, 2025
@metamaskbot
Copy link
Collaborator

Missing release label release-7.55.0 on PR. Adding release label release-7.55.0 on PR and removing other release labels(release-7.57.0), as PR was cherry-picked in branch 7.55.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.55.0 Issue or pull request that will be included in release 7.55.0 size-XS team-new-networks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants