Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add websocket support #1645

Open
danfinlay opened this issue Jun 21, 2017 · 8 comments
Open

Add websocket support #1645

danfinlay opened this issue Jun 21, 2017 · 8 comments
Assignees
@kumavis
Labels
area-api area-background Issues relating to the extension background process. type-enhancement

Comments

@danfinlay
Copy link
Contributor

Create a branch to work with Infura Websocket support.

Our websocket provider would not need to handle filters client side.

Won't need client-side filter management in the short term, for experimenting with.
@2-am-zzz 2-am-zzz added area-background Issues relating to the extension background process. P3-soon type-enhancement labels Jun 27, 2017
@2-am-zzz 2-am-zzz added this to the Core Maintenance milestone Jun 27, 2017
@cjeria cjeria removed this from the Core Maintenance milestone Jan 22, 2018
@danfinlay danfinlay mentioned this issue Jan 30, 2018
Closed
1 task
@danfinlay danfinlay added P1-asap and removed P3-soon labels Jan 30, 2018
@danfinlay danfinlay mentioned this issue Jan 30, 2018
Open
4 tasks
@danfinlay
Copy link
Contributor Author

Raising priority because it will allow a tighter integration with ganache to detect provider changes. #1999.

@danfinlay danfinlay mentioned this issue Jan 30, 2018
Closed
@bdresser bdresser added the Epic label Jun 6, 2018
@bdresser
Copy link
Contributor

bdresser commented Jun 6, 2018

@danfinlay @kumavis i've converted this to an epic to reflect what we discussed this morning. please rename & add/remove stories as necessary - not sure if this is to be framed as websocket support, subscription support, or general web3 1.0 support since they seem quite interrelated

@bdresser
Copy link
Contributor

relates to #4279

@bdresser bdresser mentioned this issue Aug 15, 2018
Merged
20 tasks
@bdresser bdresser removed the Epic label Nov 26, 2018
@d10r d10r mentioned this issue Nov 20, 2019
Closed
@d10r
Copy link

d10r commented Nov 21, 2019

So, websocket connections aren't yet supported in Metamask, correct?
I'm currently using a websocket RPC connection (readonly) in some Dapps, in parallel to the Metamask provided connection, in order to have the UI react faster to on-chain changes.

From this issue, it's not clear to me if websocket support is to be expected anytime soon. That would help me decide if I should treat the extra code for that workaround as temporary, or if I should be prepared to live with it for a bit longer and thus give it some more love.

@danfinlay
Copy link
Contributor Author

It is not yet supported, and it isn't one of our top priorities at the moment, so I would expect to live with other approaches for a bit longer, sorry!

@Gudahtt Gudahtt removed the U1-dev label Jul 28, 2020
@wbt wbt mentioned this issue Aug 21, 2020
Open
@Gudahtt Gudahtt removed the P2-sooner label Nov 23, 2020
@enolan enolan mentioned this issue Nov 27, 2020
Closed
@danjm danjm added the area-api label Sep 24, 2021
@markg85
Copy link

markg85 commented Dec 8, 2021

Any update on this, as we're well over 2 years later since the last comment.

@testermumatstudio
Copy link

How can I make use of metamask using an email, I'll explain the project a little to see if you can guide me on how I should do it, if I create a video game in unity for playstation how do I connect the metamask it's not possible!! I should authenticate with an email and that it connects to metamask I can think of an application for the intermission, you authenticate with email on the playstation it sends a connection to a mobile app to pass the info to the metamask metamask passes the data aal mail and return to playstation is it possible? how can I do it? can you guide me please I am willing to work on it and upload it opensource

@EvelinaBuiciag
Copy link

Hi,
Any updates on this? on adding websocket support in metamask ??

Thank you

@DDDDDanica DDDDDanica mentioned this issue Dec 1, 2023
Merged
13 tasks
DDDDDanica added a commit that referenced this issue Dec 4, 2023
@DDDDDanica
fix(000): remove # in pull request template as it will auto generate …
c8c2b5d 
…if linking a ticket (#22124)

## **Description**

When past an url of ticket in PR template, the # is auto generated eg:
pasting `https://github.com/MetaMask/metamask-extension/issues/1645`
will result in
#1645

## **Related issues**

Fixes: #

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've clearly explained what problem this PR is solving and how it
is solved.
- [ ] I've linked related issues
- [ ] I've included manual testing steps
- [ ] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [ ] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@gauthierpetetin gauthierpetetin mentioned this issue Dec 4, 2023
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kumavis kumavis

Labels
area-api area-background Issues relating to the extension background process. type-enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests