Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: New BlockTracker and Json-Rpc-Engine based Provider #4279

Merged
merged 111 commits into from
Aug 15, 2018

Conversation

kumavis
Copy link
Member

@kumavis kumavis commented May 17, 2018

  • move to away from provider engine
    • configure network via json-rpc-engine
    • remove provider._blockTracker and provider.on('block') usage
    • remove provider-engine dep
    • remove docs mentioning provider-engine dep
  • move to eth-block-tracker@4
    • update block event handlers
      • eth-json-rpc-filters
      • recent-block controller
      • balance controller
      • tx controller
      • nonce-tracker
      • others??
      • fix missing block on block body requests
    • update eth-block-tracker dep to use semver

bonus:

  • add subs support
  • dont subscribe to blocks unless necessary
  • dedupe repeated code in controllers/network/createXyzClient
  • publish createBlockTrackerInspectorMiddleware
  • nonce-tracker _getCurrentBlock -> await getLatestBlock()

@kumavis kumavis added the DO-NOT-MERGE Pull requests that should not be merged label May 17, 2018
@metamaskbot
Copy link
Collaborator

Builds ready [7918240]: mascara, chrome, firefox, edge, opera

@bdresser
Copy link
Contributor

bdresser commented Aug 15, 2018

Couple weeks back we grouped a bunch of issues that were possibly going to be addressed by this PR. @frankiebee @kumavis would you mark off what's handled and I'll leave the rest open?

Copy link
Contributor

@danfinlay danfinlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's begin the process of trying this out on develop!

@danfinlay danfinlay merged commit 955ec2d into develop Aug 15, 2018
@kumavis
Copy link
Member Author

kumavis commented Aug 15, 2018

@bdresser thanks for that list! some of them may be complete but are not QA'd

@bdresser bdresser removed the DO-NOT-MERGE Pull requests that should not be merged label Aug 16, 2018
@whymarrh whymarrh deleted the network-remove-provider-engine branch August 16, 2018 13:36
@saturnial
Copy link

Hi there! When can we expect this fix to be available to the public?

We're currently experiencing issues where our calls to read data from the blockchain are hitting the cache -- preventing us from seeing updated data when transactions are newly mined.

We believe this to be caused by the caching policy embedded in MetaMask but would love to confirm this...

Thanks!

@danfinlay
Copy link
Contributor

We're hoping to start rolling this branch out this week, but it depends on the number of bugs our team finds (we have it on develop branch now).

@tarekskr
Copy link

tarekskr commented Sep 5, 2018

Hey @danfinlay , has this been rolled out yet? Any ETA? Thanks a lot!

@bdresser
Copy link
Contributor

bdresser commented Sep 5, 2018

@tarekskr still testing on develop, will likely roll out early next week!

@tarekskr
Copy link

tarekskr commented Sep 5, 2018

@bdresser this is really awesome, can't wait!!

@tmashuang tmashuang mentioned this pull request Sep 17, 2018
@tmashuang tmashuang restored the network-remove-provider-engine branch September 25, 2018 16:15
@whymarrh whymarrh deleted the network-remove-provider-engine branch November 19, 2019 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants