-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat]: Add Network Icon for ApeChain #26874
Comments
bumping the ticket |
Hi @robbiekruszynski @digiwand ! Thank you for reaching out; could you provide the SVG format of the image? 🙏 |
Hello again @digiwand @robbiekruszynski 👋 i can merge this #27841 if you guys are happy with how the logo looks! |
Perfect, will reach out later today with more details. Thank you |
@sahar-fehri We are going to update the img, after that we are good for a launch on Friday |
Hi @robbiekruszynski , i can update my PR, could you send me the updated image? Is it SVG? |
Hi @sahar-fehri, we are good to use that image. |
Ho @robbiekruszynski ; I will proceed to merging the PR then once i get a green CI. |
@robbiekruszynski PR merged. |
## **Description** Adds APE network icon [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27841?quickstart=1) ## **Related issues** Fixes: #26874 ## **Manual testing steps** 1. Click on network picker and click on add custom network 2. ADD name "APE"; RPC: https://curtis.rpc.caldera.xyz/http and chainId 33111 3. Click on add network 4. You should see network icon ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> https://github.com/user-attachments/assets/89abe1e2-49e4-46ba-ada5-953fa99aa9c0 ### **After** https://github.com/user-attachments/assets/d47f9b55-f5c1-4d07-a025-34c8008eef5f ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Hi @sahar-fehri , following the steps to add I'm not getting the same results with the logo appearing post network add |
Hi @robbiekruszynski ! Could you share a video of the results you are seeing? 🙏 |
What is this about?
Add support network icon for ApeChain
Requested by members of Yuga Labs
Details:
Mainnet
TBD
Testnet RPC:
testnet
Network Name
Curtis
RPC URL
https://curtis.rpc.caldera.xyz/http
Chain ID
33111
Currency Symbol
APE
Block Explorer
https://curtis.explorer.caldera.xyz/
Requires:
Scenario
No response
Design
No response
Technical Details
No response
Threat Modeling Framework
No response
Acceptance Criteria
No response
Stakeholder review needed before the work gets merged
References
No response
The text was updated successfully, but these errors were encountered: