Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: Add Network Icon for ApeChain #26874

Closed
1 of 11 tasks
digiwand opened this issue Sep 3, 2024 · 12 comments · Fixed by #27841
Closed
1 of 11 tasks

[Feat]: Add Network Icon for ApeChain #26874

digiwand opened this issue Sep 3, 2024 · 12 comments · Fixed by #27841
Labels
area-customNetworks release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-assets team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead type-enhancement

Comments

@digiwand
Copy link
Contributor

digiwand commented Sep 3, 2024

What is this about?

Add support network icon for ApeChain

Requested by members of Yuga Labs

Details:

Mainnet

TBD

Testnet RPC:

testnet

Network Name
Curtis

RPC URL
https://curtis.rpc.caldera.xyz/http

Chain ID
33111

Currency Symbol
APE

Block Explorer
https://curtis.explorer.caldera.xyz/

Requires:

  • png version of icon image
  • chain id of RPC mainnet network

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response

@digiwand digiwand added type-enhancement area-customNetworks team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead team-assets labels Sep 3, 2024
@onwardyuga
Copy link

apechain

@robbiekruszynski
Copy link

bumping the ticket

@sahar-fehri
Copy link
Contributor

sahar-fehri commented Oct 14, 2024

Hi @robbiekruszynski @digiwand ! Thank you for reaching out; could you provide the SVG format of the image? 🙏

@sahar-fehri
Copy link
Contributor

Hello again @digiwand @robbiekruszynski 👋 i can merge this #27841 if you guys are happy with how the logo looks!

@robbiekruszynski
Copy link

Perfect, will reach out later today with more details. Thank you

@robbiekruszynski
Copy link

@sahar-fehri We are going to update the img, after that we are good for a launch on Friday

@sahar-fehri
Copy link
Contributor

Hi @robbiekruszynski , i can update my PR, could you send me the updated image? Is it SVG?

@robbiekruszynski
Copy link

Hi @sahar-fehri, we are good to use that image.
Can you share your telegram to send a message directly?

@sahar-fehri
Copy link
Contributor

sahar-fehri commented Oct 17, 2024

Ho @robbiekruszynski ; I will proceed to merging the PR then once i get a green CI.

@sahar-fehri
Copy link
Contributor

@robbiekruszynski PR merged.

github-merge-queue bot pushed a commit that referenced this issue Oct 17, 2024
## **Description**

Adds APE network icon

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27841?quickstart=1)

## **Related issues**

Fixes: #26874

## **Manual testing steps**

1. Click on network picker and click on add custom network
2. ADD name "APE"; RPC: https://curtis.rpc.caldera.xyz/http and chainId
33111
3. Click on add network
4. You should see network icon

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->


https://github.com/user-attachments/assets/89abe1e2-49e4-46ba-ada5-953fa99aa9c0


### **After**



https://github.com/user-attachments/assets/d47f9b55-f5c1-4d07-a025-34c8008eef5f



## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 17, 2024
@robbiekruszynski
Copy link

Hi @sahar-fehri , following the steps to add I'm not getting the same results with the logo appearing post network add

@sahar-fehri
Copy link
Contributor

Hi @robbiekruszynski ! Could you share a video of the results you are seeing? 🙏

@gauthierpetetin gauthierpetetin added release-12.6.0 Issue or pull request that will be included in release 12.6.0 and removed release-12.7.0 Issue or pull request that will be included in release 12.7.0 labels Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-customNetworks release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-assets team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead type-enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants