fix: add APE network icon #27841

sahar-fehri · 2024-10-14T15:41:59Z

Description

Adds APE network icon

Related issues

Fixes: #26874

Manual testing steps

Click on network picker and click on add custom network
ADD name "APE"; RPC: https://curtis.rpc.caldera.xyz/http and chainId 33111
Click on add network
You should see network icon

Screenshots/Recordings

Before

Screen.Recording.2024-10-14.at.17.40.08.mov

After

Screen.Recording.2024-10-14.at.17.37.58.mov

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-10-14T15:42:12Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

shared/constants/network.ts

sonarqubecloud · 2024-10-16T17:04:06Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-10-16T17:24:53Z

Builds ready [cc13dc7]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2048 ± 89 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	287	2529	1971	427	205
		domContentLoaded	1727	2520	1997	188	90
		load	1782	2540	2048	185	89
		domInteractive	17	241	65	61	29

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 110 Bytes (0.00%)

gambinish

LGTM but looks like we may need to rerun a ci workflow

andreahaku

LGTM

metamaskbot · 2024-10-17T16:45:03Z

Builds ready [167d75a]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1877 ± 159 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1472	3068	1888	331	159
		domContentLoaded	1463	3047	1849	330	159
		load	1474	3074	1877	331	159
		domInteractive	15	190	53	37	18
		backgroundConnect	10	87	34	25	12
		firstReactRender	44	230	92	39	19
		getState	4	90	25	27	13
		initialActions	0	1	0	0	0
		loadScripts	1063	2479	1358	281	135
		setupStore	11	97	30	26	13
		uiStartup	1674	3313	2112	371	178

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 110 Bytes (0.00%)

metamaskbot · 2024-10-17T16:50:50Z

Builds ready [167d75a]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1877 ± 159 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1472	3068	1888	331	159
		domContentLoaded	1463	3047	1849	330	159
		load	1474	3074	1877	331	159
		domInteractive	15	190	53	37	18
		backgroundConnect	10	87	34	25	12
		firstReactRender	44	230	92	39	19
		getState	4	90	25	27	13
		initialActions	0	1	0	0	0
		loadScripts	1063	2479	1358	281	135
		setupStore	11	97	30	26	13
		uiStartup	1674	3313	2112	371	178

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 110 Bytes (0.00%)

fix: add APE network icon

eff256f

sahar-fehri requested a review from a team as a code owner October 14, 2024 15:42

sahar-fehri added the needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. label Oct 14, 2024

github-actions bot added the team-assets label Oct 14, 2024

sahar-fehri requested review from salimtb, gambinish and bergeron October 14, 2024 15:42

sahar-fehri mentioned this pull request Oct 14, 2024

[Feat]: Add Network Icon for ApeChain #26874

Closed

11 tasks

salimtb previously approved these changes Oct 14, 2024

View reviewed changes

NidhiKJha previously approved these changes Oct 14, 2024

View reviewed changes

digiwand previously approved these changes Oct 15, 2024

View reviewed changes

shared/constants/network.ts Outdated Show resolved Hide resolved

fix: nit reorder

cc13dc7

sahar-fehri dismissed stale reviews from digiwand, NidhiKJha, and salimtb via cc13dc7 October 16, 2024 16:51

sahar-fehri requested review from digiwand, salimtb and NidhiKJha October 16, 2024 16:52

gambinish approved these changes Oct 16, 2024

View reviewed changes

andreahaku approved these changes Oct 17, 2024

View reviewed changes

Merge branch 'develop' into fix/add-network-logo-for-ape

167d75a

salimtb enabled auto-merge October 17, 2024 12:01

salimtb disabled auto-merge October 17, 2024 12:01

salimtb approved these changes Oct 17, 2024

View reviewed changes

sahar-fehri added this pull request to the merge queue Oct 17, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 17, 2024

sahar-fehri added this pull request to the merge queue Oct 17, 2024

Merged via the queue into develop with commit 654dff7 Oct 17, 2024
76 checks passed

sahar-fehri deleted the fix/add-network-logo-for-ape branch October 17, 2024 18:08

github-actions bot locked and limited conversation to collaborators Oct 17, 2024

metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 17, 2024

gauthierpetetin added release-12.6.0 Issue or pull request that will be included in release 12.6.0 and removed release-12.7.0 Issue or pull request that will be included in release 12.7.0 labels Oct 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: add APE network icon #27841

fix: add APE network icon #27841

sahar-fehri commented Oct 14, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Oct 14, 2024

sonarqubecloud bot commented Oct 16, 2024

metamaskbot commented Oct 16, 2024

gambinish left a comment

andreahaku left a comment

metamaskbot commented Oct 17, 2024

metamaskbot commented Oct 17, 2024

fix: add APE network icon #27841

fix: add APE network icon #27841

Conversation

sahar-fehri commented Oct 14, 2024 • edited by github-actions bot Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Oct 14, 2024

sonarqubecloud bot commented Oct 16, 2024

Quality Gate passed

metamaskbot commented Oct 16, 2024

gambinish left a comment

Choose a reason for hiding this comment

andreahaku left a comment

Choose a reason for hiding this comment

metamaskbot commented Oct 17, 2024

metamaskbot commented Oct 17, 2024

sahar-fehri commented Oct 14, 2024 •

edited by github-actions bot

Loading