Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Onboarding - After adding a network while in the Onboarding Settings page, I land into the Password screen and when Iog in I land again into the Onboarding page #28097

Closed
seaona opened this issue Oct 25, 2024 · 6 comments · Fixed by #28165
Closed

[Bug]: Onboarding - After adding a network while in the Onboarding Settings page, I land into the Password screen and when Iog in I land again into the Onboarding page #28097

seaona opened this issue Oct 25, 2024 · 6 comments · Fixed by #28165
Labels
regression-RC-12.6.0 Regression bug that was found in release candidate (RC) for release 12.6.0 release-12.7.0 Issue or pull request that will be included in release 12.7.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-wallet-ux type-bug

Comments

@seaona
Copy link
Contributor

seaona commented Oct 25, 2024

Describe the bug

When I am performing the Onboarding flow, if I go to General Settings and I add a network, I see how I land automatically to the Password page.
This seems wrong. After I add my newly created password, I land back again into the Onboarding page Your Wallet is Ready.

Expected behavior

After adding a network, I should remain into the Onbording General Settings page

Screenshots/Recordings

add-net-land-password.mp4

Steps to reproduce

  1. Start the onboarding
  2. Click Manage Settings
  3. Go to General Settings
  4. Click Add network
  5. Click Arrow back
  6. Add any popular network
  7. See how you land into the Password page
  8. Log in
  9. See how you land back to the Your wallet is ready page

Error messages or log output

No response

Detection stage

During release testing

Version

12.6.0

Build type

None

Browser

Chrome

Operating system

Linux

Hardware wallet

No response

Additional context

No response

Severity

No response
@seaona seaona added type-bug Sev2-normal Normal severity; minor loss of service or inconvenience. team-wallet-ux regression-RC-12.6.0 Regression bug that was found in release candidate (RC) for release 12.6.0 labels Oct 25, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Oct 25, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Oct 25, 2024
@seaona seaona added the release-blocker This bug is blocking the next release label Oct 25, 2024
@seaona
Copy link
Contributor Author

seaona commented Oct 25, 2024

ℹ️ Added the release-blocker tag just in case, given the onboarding change is new, but feel free to re-assess if needed

@NidhiKJha
Copy link
Member

@seaona I am not able to repro this bug.
https://github.com/user-attachments/assets/7bc5bbb5-dd30-4391-8f40-952423705647

@seaona
Copy link
Contributor Author

seaona commented Oct 29, 2024

hey @NidhiKJha I'm able to reproduce this consistently.
I'm using the 12.6.0 Chrome dist build from the RC branch. Which build were you using?

darkwing added a commit that referenced this issue Oct 29, 2024
@darkwing
Fix #28097 - Prevent redirect after adding network in Onboarding Sett…
62c2bab 
…ings
darkwing added a commit that referenced this issue Oct 29, 2024
@darkwing
Fix #28097 - Prevent redirect after adding network in Onboarding Sett…
fff1dfd 
…ings
@darkwing darkwing mentioned this issue Oct 29, 2024
Merged
7 tasks
@hesterbruikman
Copy link

@seaona can you confirm that you're uses an Imported account? I can reproduce, but only when importing.

@hesterbruikman hesterbruikman removed the release-blocker This bug is blocking the next release label Oct 30, 2024
@hesterbruikman
Copy link

Removing the release-blocker label. While a clunky experience we want to improve, the flow to is not expected to occur frequently. Thanks for providing a fix @darkwing . If we can get it merged and into release, great, but @vpintorico I would not block release for it. Too much going out and on cadence.

@seaona
Copy link
Contributor Author

seaona commented Oct 30, 2024

I see this happenning when you are performing the Onboarding flow both with Create New Wallet and Import Wallet.

Thank you for taking a look! It make sense to me @hesterbruikman

@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Oct 30, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Oct 30, 2024
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 30, 2024
kanthesha pushed a commit that referenced this issue Oct 30, 2024
@darkwing
fix: Fix #28097 - Prevent redirect after adding network in Onboarding…
9cc7b41 
… Settings (#28165)

## **Description**

Prevents the post-add-network redirect from happening if the user is on
the onboarding screen.

## **Related issues**

Fixes: #28097

## **Manual testing steps**

STR's are in #28097

## **Screenshots/Recordings**

### **Before**

### **After**



https://github.com/user-attachments/assets/ed136a3f-e06c-4c78-a76f-fd08a9865390



## **Pre-merge author checklist**

- [X] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding

Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [X] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [X] I’ve applied the right labels on the PR (see [labeling

guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression-RC-12.6.0 Regression bug that was found in release candidate (RC) for release 12.6.0 release-12.7.0 Issue or pull request that will be included in release 12.7.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-wallet-ux type-bug
Projects
Bugs by severity
Archived in project
Milestone
No milestone
5 participants
@hesterbruikman @metamaskbot @NidhiKJha @seaona and others