fix: Fix #28097 - Prevent redirect after adding network in Onboarding Settings

[darkwing]

Description

Prevents the post-add-network redirect from happening if the user is on the onboarding screen.

Related issues

Fixes: #28097

Manual testing steps

STR's are in #28097

Screenshots/Recordings

Before

After

Screen.Recording.2024-10-29.at.12.49.56.PM.mov

Pre-merge author checklist

• I've followed MetaMask Contributor
  Docs and MetaMask
  Extension Coding
  Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format
  if applicable
• I’ve applied the right labels on the PR (see labeling
  guidelines).
  Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the
  app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described
  in the ticket it closes and includes the necessary testing evidence such
  as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[bergeron]

Good fix. I noticed this too but wasn't sure how to fix it. I was trying use state.metamask.completedOnboarding to determine whether to redirect, but didn't know how to access it here. document.location seems like it'll work

[metamaskbot]

Builds ready [fff1dfd]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2082 ± 109 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	334	2601	1908	549	263
		domContentLoaded	1791	2518	2055	225	108
		load	1801	2607	2082	227	109
		domInteractive	27	140	54	27	13
		backgroundConnect	7	88	30	23	11
		firstReactRender	51	289	111	64	31
		getState	5	71	23	23	11
		initialActions	0	1	0	0	0
		loadScripts	1317	2007	1534	214	103
		setupStore	12	86	40	26	13
		uiStartup	2081	2801	2344	218	105

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 79 Bytes (0.00%)