[Bug]: Infinite Load after upgrade to 12.9.0
#29055
Comments
metamaskbot
added
external-contributor
regression-prod-12.9.0
|
Guys, that release is fucked up. After 5mins I got to the main screen finally. I can't switch chains (it doesn't react), if I click again on the MetaMask pop it gets me this forever |
|
Adding a network is now taking 2 mins...
|
DanielTech21
added
Sev1-high
|
Thank you for reporting it to us. Our team will look into this and get back to you. |
|
@pcaversaccio Could you open the developer console and check if there are any errors?
|
|
yeah there are some errors indeed (probably from the RPC, haven't checked so far): debug.log |
|
thanks, we are investigating |
|
there are definitely some RPC errors. Are you able to change RPCs? Also, did you have a large number of accounts added to your metamask install? |
So before upgrading this morning everything run smoothly. Changing RPCs don't fix anything so far. I didn't add any accounts recently. But I have a lot of networks configured (almost 100 networks I guess) |
|
okay, that's useful to know |
|
Example: When I change the network from Linea Infura to Ethereum Mainnet Infura it takes around 25-30s. |
|
We are actively investigating, but something you could try in the meantime that might alleviate the problems you are seeing: On the "Tokens" tab on the home screen, there is a new dropdown that says "All Networks". Click the dropdown and select something other than "All networks". Example video here: Screencast.2024-12-10.14.19.04.mp4Can you try that and let us know whether it improves things for you? |
This is what happens when I do it first
after I reloaded crashed again, and the third time it worked but not really faster tbh. |
|
okay, thank-you again for the info you are sharing. It is very helpful |
|
Now that you switched away from that "All Networks" setting, you may need to reload the extension to correct performance. To do so, you can go to chrome://extensions, and toggle MetaMask on and off (using the blue toggle in the bottom right corner of the box that contains metamask)
|
Alright - this makes it definitely work again as previously (almost). But that "All Networks" tab breaks really everything for me... |
|
yeah, we'll fix that |
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** To reduce the impact of showing assets across all networks, which can be unbounded, this PR scopes the portfolio view to the 9 popular networks built into metamask. [](https://codespaces.new/MetaMask/metamask-extension/pull/29071?quickstart=1) ## **Related issues** Fixes: #29055 ## **Manual testing steps** 1. On popular networks: - The token filter should allow switching between popular networks and current network - The filter should work as described - RPC requests in the background should only hit the popular networks 2. On other networks - The token filter should become disabled and scoped to the current network - RPC requests in the background should only hit the current network ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Nicholas Gambino <nicholas.gambino@consensys.net>
metamaskbot
added
the
release-12.10.1
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> To reduce the impact of showing assets across all networks, which can be unbounded, this PR scopes the portfolio view to the 9 popular networks built into metamask. [](https://codespaces.new/MetaMask/metamask-extension/pull/29071?quickstart=1) Fixes: #29055 1. On popular networks: - The token filter should allow switching between popular networks and current network - The filter should work as described - RPC requests in the background should only hit the popular networks 2. On other networks - The token filter should become disabled and scoped to the current network - RPC requests in the background should only hit the current network <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> <!-- [screenshots/recordings] --> <!-- [screenshots/recordings] --> - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Nicholas Gambino <nicholas.gambino@consensys.net>
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** To reduce the impact of showing assets across all networks, which can be unbounded, this PR scopes the portfolio view to the 9 popular networks built into metamask. <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Related issues** Fixes: MetaMask/metamask-extension#29055 ## **Manual testing steps** 1. On popular networks: - The token filter should allow switching between popular networks and current network - The filter should work as described - RPC requests in the background should only hit the popular networks 2. On other networks - The token filter should become disabled and scoped to the current network - RPC requests in the background should only hit the current network ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** https://github.com/user-attachments/assets/a65afd42-b67e-401e-b33c-b46fad3dd812 https://github.com/user-attachments/assets/e2179b4c-c3da-43d1-86d3-50fc066f0899 <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
metamaskbot
added
the
release-99.100.99
](https://codespaces.new/MetaMask/metamask-extension/pull/29071?quickstart=1){kind=link}
Describe the bug
I just updated to the latest version
12.9.0and it keeps loading forever when I log in. Before you ask, yes I cleared the cache, yes I restarted the browser, yes I checked that it's the correct MetaMask version. Previously I had no such issue.Expected behavior
No response
Screenshots/Recordings
No response
Steps to reproduce
Error messages or log output
Detection stage
In production (default)
Version
12.9.0
Build type
None
Browser
Microsoft Edge
Operating system
Windows
Hardware wallet
No response
Additional context
No response
Severity
No response
The text was updated successfully, but these errors were encountered: