Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: only poll popular networks #29071

Merged
merged 18 commits into from
Dec 11, 2024
Merged

feat: only poll popular networks #29071

merged 18 commits into from
Dec 11, 2024

Conversation

bergeron
Copy link
Contributor

@bergeron bergeron commented Dec 10, 2024

Description

To reduce the impact of showing assets across all networks, which can be unbounded, this PR scopes the portfolio view to the 9 popular networks built into metamask.

Open in GitHub Codespaces

Related issues

Fixes: #29055

Manual testing steps

  1. On popular networks:
  • The token filter should allow switching between popular networks and current network
  • The filter should work as described
  • RPC requests in the background should only hit the popular networks
  1. On other networks
  • The token filter should become disabled and scoped to the current network
  • RPC requests in the background should only hit the current network

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@bergeron bergeron changed the title Brian/popular2 feat: only poll popular networks Dec 10, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@darkwing darkwing added the portfolio-view Used for PRs and issues related to Q4 2024 portfolio view label Dec 10, 2024
@bergeron
Copy link
Contributor Author

depends on #29068

@bergeron bergeron marked this pull request as ready for review December 11, 2024 00:00
@bergeron bergeron requested a review from a team as a code owner December 11, 2024 00:00
Base automatically changed from fix/12.9-token-network-filter-undefined to main December 11, 2024 00:13
darkwing
darkwing previously approved these changes Dec 11, 2024
@bergeron
Copy link
Contributor Author

fixing e2e test

@metamaskbot
Copy link
Collaborator

Builds ready [bd1560f]
Page Load Metrics (1798 ± 84 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14832280179818187
domContentLoaded14722217177417283
load14812232179817684
domInteractive257642167
backgroundConnect107124178
firstReactRender1784432613
getState565232210
initialActions01000
loadScripts10591729132715173
setupStore74812126
uiStartup16732523200219292
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 152 Bytes (0.00%)
  • common: 254 Bytes (0.00%)

@gambinish gambinish self-requested a review December 11, 2024 03:43
@bergeron bergeron added this pull request to the merge queue Dec 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 11, 2024
@bergeron bergeron added this pull request to the merge queue Dec 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 11, 2024
@bergeron bergeron added this pull request to the merge queue Dec 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 11, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [b4a7e38]
Page Load Metrics (1694 ± 58 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15001924169612459
domContentLoaded14451902167112258
load15031972169412258
domInteractive257246167
backgroundConnect97026199
firstReactRender1674412412
getState567182010
initialActions01000
loadScripts10821513126710852
setupStore75914147
uiStartup16872175190113163
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 152 Bytes (0.00%)
  • common: 254 Bytes (0.00%)

@bergeron bergeron enabled auto-merge December 11, 2024 06:37
@bergeron bergeron added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit 07d4265 Dec 11, 2024
75 checks passed
@bergeron bergeron deleted the brian/popular2 branch December 11, 2024 10:32
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2024
@metamaskbot metamaskbot added the release-12.10.1 Issue or pull request that will be included in release 12.10.1 label Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
portfolio-view Used for PRs and issues related to Q4 2024 portfolio view release-12.10.1 Issue or pull request that will be included in release 12.10.1 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Infinite Load after upgrade to 12.9.0
4 participants