-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: only poll popular networks #29071
Merged
Merged
+73
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…MetaMask/metamask-extension into brian/popular2
…MetaMask/metamask-extension into brian/popular2
darkwing
added
the
portfolio-view
Used for PRs and issues related to Q4 2024 portfolio view
label
Dec 10, 2024
depends on #29068 |
gambinish
reviewed
Dec 11, 2024
Base automatically changed from
fix/12.9-token-network-filter-undefined
to
main
December 11, 2024 00:13
darkwing
previously approved these changes
Dec 11, 2024
fixing e2e test |
Builds ready [bd1560f]
Page Load Metrics (1798 ± 84 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
darkwing
approved these changes
Dec 11, 2024
gambinish
approved these changes
Dec 11, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 11, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 11, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 11, 2024
Builds ready [b4a7e38]
Page Load Metrics (1694 ± 58 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
metamaskbot
added
the
release-12.10.1
Issue or pull request that will be included in release 12.10.1
label
Dec 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
portfolio-view
Used for PRs and issues related to Q4 2024 portfolio view
release-12.10.1
Issue or pull request that will be included in release 12.10.1
team-assets
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To reduce the impact of showing assets across all networks, which can be unbounded, this PR scopes the portfolio view to the 9 popular networks built into metamask.
Related issues
Fixes: #29055
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist