Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid prop error during onboarding flow #6760

Closed
ryanml opened this issue Jun 27, 2019 · 0 comments · Fixed by #6761
Closed

Invalid prop error during onboarding flow #6760

ryanml opened this issue Jun 27, 2019 · 0 comments · Fixed by #6761

Comments

@ryanml
Copy link
Contributor

ryanml commented Jun 27, 2019

Describe the bug
A prop (nextRoute) for FirstTimeFlow is incorrectly typed as a function, when it should be a string.

Other examples of its correct use:
https://github.com/MetaMask/metamask-extension/blob/develop/ui/app/pages/first-time-flow/metametrics-opt-in/metametrics-opt-in.component.js#L9

https://github.com/MetaMask/metamask-extension/blob/develop/ui/app/pages/first-time-flow/select-action/select-action.component.js#L13

To Reproduce

  1. Start a clean build of MetaMask
  2. Click 'Let's get started', then go to create a password
  3. Note the screenshot for the error in the console

Expected behavior
Prop should be typed as a string, no console errors

Screenshots
Screen Shot 2019-06-26 at 5 58 20 PM

Browser details (please complete the following information):

  • OS: [e.g. OS X, Windows]
  • Browser [e.g. chrome, safari]
  • MetaMask Version [e.g. 5.0.2]

Additional context
Add any other context about the problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant