Version 6.7.2 Release Candidate #6780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
transactions - always hexprefix txParams on update; fixes #6724
Add brave as a platform type for MetaMask
Document hotfix protocol
There is currently a bug in chrome that prevents reading source maps from a local file [0]. This was preventing Chrome DevTools from using our JavaScript source maps, where were saved as `.map` files. To work around this problem the source maps are now generated inline, which seems to work fine. The only other browser I tested this with was Firefox, which works both before and after this change. [0]: https://bugs.chromium.org/p/chromium/issues/detail?id=931675
The source maps generated previously were mapping the bundled files to the post-Babel files - they weren't showing mapping to the source files as written. It looks like this was a result of `reactify` being used in addition to babel - that transformation must have dropped the source maps. `reactify` still needs to be listed as a dependency because it is an unlisted requirement of the `boron` package, which we use. We don't need to use it to create our bundles though, as Babel already performs the transformations we need.
The only package that needed to be updated was `sha3`. It has been updated to v1.2.3, which is a maintenance release that supports up to Node.js v12.
Refactor the AccountDetailsModal to follow newer conventions. Changes include: - Create a directory for the component with separate files for the component, the container, and the entrypoint. - Use jsx rather than hyperscript Fixes #6741
The back button on the import seed phrase page leaves the Redux store with `appState.forgottenPassword` set to true, which prevents the user from logging in. That flag is now unset when the user leaves the page. Fixes #6740
* Add tests for ImportWithSeedPhrase#parseSeedPhrase * Handle importing whitespace-only seed phrases Fixes #6694 This changeset fixes our parsing of seed phrases during import to handle the case where a user tries to import a seed phrase that consists solely of whitespace. We no longer produce an error and instead treat it as an incorrect seed phrase. * Handle importing more invalid seed phrases
Update to Node.js v10
* Normalize and Validate txParams in TransactionStateManager.addTx too * Added Tests * Updated normalizeAndValidateParams to return the new txParams
Using admin privilege to bypass code owner review because it has already [been reviewed](#6763) and those code owners are out today.
frankiebee
previously approved these changes
Jul 1, 2019
This was referenced Jul 1, 2019
tmashuang
previously approved these changes
Jul 1, 2019
* Introduce delay for eth_estimateGas calls with in test * Add test that fails when gas estimates of contract method calls without gas are too high. * Get transaction gas data from unApprovedTxs instead of confirmTransaction * Fix selection of gas data in gas-modal-page-container.container * Lint changes related to Version-6.7.2-gasLimitFix * Fix e2e tests on Version-6.7.2-gasLimitFix * Fix unit and integration tests for changes from Version-6.7.2-gasLimitFix * more e2e fixes * Add assertions for transaction values on confirm screen * Fix display of transaction amount on confirm screen.
tmashuang
approved these changes
Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening as a release candidate because there is an active bug in production related to gas limits, but I haven't reproduced on our latest
developbranch, so I want to invite developers to test if they can reproduce the issue now:Changelog: