Use inline source maps in development #6754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, didn't realize this would affect the dist build as well. I'll have to update this to use inline source maps for development, but leave the dist build unaffected. |
Gudahtt
force-pushed
the
inline-source-maps
branch
from
37db1f4 to
76e31cd
Compare
There is currently a bug in chrome that prevents reading source maps from a local file [0]. This was preventing Chrome DevTools from using our JavaScript source maps, where were saved as `.map` files. To work around this problem the source maps are now generated inline, which seems to work fine. The only other browser I tested this with was Firefox, which works both before and after this change. [0]: https://bugs.chromium.org/p/chromium/issues/detail?id=931675
Gudahtt
force-pushed
the
inline-source-maps
branch
from
76e31cd to
374171b
Compare
Gudahtt
changed the title
whymarrh
approved these changes
Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently a bug in chrome that prevents reading source maps from a local file. This was preventing Chrome DevTools from using our JavaScript source maps, where were saved as
.mapfiles. To work around this problem the source maps are now generated inline, which seems to work fine.The only other browser I tested this with was Firefox, which works both before and after this change.