Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix metametrics option tracking #10071

Merged
merged 1 commit into from
Dec 14, 2020
Merged

Conversation

brad-decker
Copy link
Contributor

in #9222, which aimed at removing negated conditions, we accidentally introduced a change in how we filtered events from firing on the metrics opt-in page.

Previously, we checked if the previous value for participateInMetaMetrics was not equal to what we were tracking. e.g: if the user was opting in, we made sure the previous participateInMetaMetrics was not true. The change made it such that it would only track an event if the previous participateInMetaMetrics was strictly the inverse of the user's intention. e.g: if the user was opting in, we made sure the previous participateInMetaMetrics was false.

The problem here is that all new users default this value to null, which would have been fine in the previous version but not find in the new version.

This issue landed in 8.1.0 on Oct 13, and subsequently, 8.1.3 which migrated us off of matomo landed on oct 28. Due to chrome review times and what not, there probably wasn't a huge gap between when the bug was rolled out to most of our chrome users and when matomo was removed for most of our chrome users.

@brad-decker brad-decker requested a review from Gudahtt December 14, 2020 21:38
@metamaskbot
Copy link
Collaborator

Builds ready [52afb4f]
Page Load Metrics (539 ± 21 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30584584
domContentLoaded4926825384421
load4946845394421
domInteractive4926825374421

@brad-decker brad-decker marked this pull request as ready for review December 14, 2020 21:51
@brad-decker brad-decker requested a review from a team as a code owner December 14, 2020 21:51
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great catch!

@brad-decker brad-decker merged commit 3cabe75 into develop Dec 14, 2020
@brad-decker brad-decker deleted the fix-metametrics-option-tracking branch December 14, 2020 21:54
@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants