Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in #9222, which aimed at removing negated conditions, we accidentally introduced a change in how we filtered events from firing on the metrics opt-in page.
Previously, we checked if the previous value for
participateInMetaMetrics
was not equal to what we were tracking. e.g: if the user was opting in, we made sure the previousparticipateInMetaMetrics
was not true. The change made it such that it would only track an event if the previousparticipateInMetaMetrics
was strictly the inverse of the user's intention. e.g: if the user was opting in, we made sure the previousparticipateInMetaMetrics
was false.The problem here is that all new users default this value to
null
, which would have been fine in the previous version but not find in the new version.This issue landed in 8.1.0 on Oct 13, and subsequently, 8.1.3 which migrated us off of matomo landed on oct 28. Due to chrome review times and what not, there probably wasn't a huge gap between when the bug was rolled out to most of our chrome users and when matomo was removed for most of our chrome users.