Fix no-negated-condition issues #9222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See [`no-negated-condition`](https://eslint.org/docs/rules/no-negated-condition) for more information. This change enables `no-negated-condition` and fixes the issues raised by the rule.
Gudahtt
approved these changes
Aug 14, 2020
| }) : '' | ||
| const dimensions = pageOpts.hideDimensions | ||
| ? '' | ||
| : ( |
There was a problem hiding this comment.
I'm curious about the parentheses introduced here - they don't seem to be required 🤔
Gudahtt
added a commit
that referenced
this pull request
Aug 14, 2020
* origin/develop: (107 commits) Clear Account Details in AppState (#9238) Permit all-caps addresses (#9227) Send web3 usage metrics once per origin/property (#9237) Fix import/no-extraneous-dependencies issues (#9232) Remove unused buyEth fn from bg (#9236) Fix max-statements-per-line issues (#9218) Consolidate ESLint config files (#9231) Delete page-container.component.test.js (#9229) Tidy up getAccountLink (#9223) Tidy ConnectHardwareForm#checkIfUnlocked (#9224) Fix require-unicode-regexp issues (#9212) Fix no-negated-condition issues (#9222) Fix no-empty-function issues (#9216) Fix import/extensions issues (#9217) Dedupe glob-parent versions (#9220) Fix no-template-curly-in-string issues (#9221) Fix no-process-exit issues (#9219) Fix prefer-rest-params issues (#9215) Fix no-prototype-builtins issues (#9213) Fix no-nested-ternary issues (#9214) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #8982
See
no-negated-conditionfor more information.This change enables
no-negated-conditionand fixes the issues raised by the rule.