Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no-process-exit issues #9219

Merged
merged 1 commit into from
Aug 13, 2020

Conversation

whymarrh
Copy link
Contributor

Refs #8982

See no-process-exit for more information.

This change enables no-process-exit and fixes the issues raised by the rule.

See [`no-process-exit`](https://eslint.org/docs/rules/no-process-exit) for more information.

This change enables `no-process-exit` and fixes the issues raised by the rule.
@whymarrh whymarrh force-pushed the enable-no-process-exit branch from 6f0a286 to aee2cf8 Compare August 13, 2020 20:39
@whymarrh whymarrh marked this pull request as ready for review August 13, 2020 20:40
@whymarrh whymarrh requested a review from a team as a code owner August 13, 2020 20:40
@whymarrh whymarrh requested a review from brad-decker August 13, 2020 20:40
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@whymarrh whymarrh merged commit 944f6d4 into MetaMask:develop Aug 13, 2020
@whymarrh whymarrh deleted the enable-no-process-exit branch August 13, 2020 21:31
Gudahtt added a commit that referenced this pull request Aug 14, 2020
* origin/develop: (107 commits)
  Clear Account Details in AppState (#9238)
  Permit all-caps addresses (#9227)
  Send web3 usage metrics once per origin/property (#9237)
  Fix import/no-extraneous-dependencies issues (#9232)
  Remove unused buyEth fn from bg (#9236)
  Fix max-statements-per-line issues (#9218)
  Consolidate ESLint config files (#9231)
  Delete page-container.component.test.js (#9229)
  Tidy up getAccountLink (#9223)
  Tidy ConnectHardwareForm#checkIfUnlocked (#9224)
  Fix require-unicode-regexp issues (#9212)
  Fix no-negated-condition issues (#9222)
  Fix no-empty-function issues (#9216)
  Fix import/extensions issues (#9217)
  Dedupe glob-parent versions (#9220)
  Fix no-template-curly-in-string issues (#9221)
  Fix no-process-exit issues (#9219)
  Fix prefer-rest-params issues (#9215)
  Fix no-prototype-builtins issues (#9213)
  Fix no-nested-ternary issues (#9214)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants