Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused buyEth from background #9236

Merged
merged 1 commit into from
Aug 14, 2020
Merged

Remove unused buyEth from background #9236

merged 1 commit into from
Aug 14, 2020

Conversation

whymarrh
Copy link
Contributor

@whymarrh whymarrh commented Aug 14, 2020 •
edited
Loading

This PR removes the unused buyEth method from the background API.

The UI action opens the URL:

metamask-extension/ui/app/store/actions.js

Lines 1817 to 1825 in add0907

export function buyEth (opts) {
return (dispatch) => {
const url = getBuyEthUrl(opts)
global.platform.openTab({ url })
dispatch({
type: actionConstants.BUY_ETH,
})
}
}

@whymarrh whymarrh changed the title Remove unused buyEth fn from bg Remove unused buyEth from background Aug 14, 2020
@whymarrh whymarrh marked this pull request as ready for review August 14, 2020 17:25
@whymarrh whymarrh requested a review from a team as a code owner August 14, 2020 17:25
@whymarrh whymarrh requested a review from rekmarks August 14, 2020 17:25
rekmarks
rekmarks approved these changes Aug 14, 2020
View reviewed changes
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@whymarrh whymarrh merged commit c2edc34 into MetaMask:develop Aug 14, 2020
@whymarrh whymarrh deleted the delete-buy-eth-bg branch August 14, 2020 18:21
@whymarrh whymarrh mentioned this pull request Aug 14, 2020
Merged
Gudahtt added a commit that referenced this pull request Aug 14, 2020
@Gudahtt
Merge remote-tracking branch 'origin/develop' into sync-master
52fd72f 
* origin/develop: (107 commits)
  Clear Account Details in AppState (#9238)
  Permit all-caps addresses (#9227)
  Send web3 usage metrics once per origin/property (#9237)
  Fix import/no-extraneous-dependencies issues (#9232)
  Remove unused buyEth fn from bg (#9236)
  Fix max-statements-per-line issues (#9218)
  Consolidate ESLint config files (#9231)
  Delete page-container.component.test.js (#9229)
  Tidy up getAccountLink (#9223)
  Tidy ConnectHardwareForm#checkIfUnlocked (#9224)
  Fix require-unicode-regexp issues (#9212)
  Fix no-negated-condition issues (#9222)
  Fix no-empty-function issues (#9216)
  Fix import/extensions issues (#9217)
  Dedupe glob-parent versions (#9220)
  Fix no-template-curly-in-string issues (#9221)
  Fix no-process-exit issues (#9219)
  Fix prefer-rest-params issues (#9215)
  Fix no-prototype-builtins issues (#9213)
  Fix no-nested-ternary issues (#9214)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rekmarks rekmarks rekmarks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whymarrh @rekmarks