Update Babel and dependencies #15392

brad-decker · 2022-07-31T19:42:35Z

Explanation

This pull request updates our babel and its dependencies. The goal here is to unlock further build system improvements as well as tap into improvements made to babel as well as unlock TypeScript 4.7 support.

Things to note:

A number of plugins, such as object rest spread, nullish coalescing and optional chaining are not part of preset-env and are no longer needed explicitly.
The 'targets' property in babel.config.js is moved to the top level scope instead of preset-env.
Babel runtime was updated and patched in a similar fashion as the previous version.

More Information

I am keeping a close eye on the MV3 metrics in relation to this PR. Once i'm solid i'm going to ask for @jpuri to do an analysis of the impact.

TODO:

Confirm that adding/removing babel-runtime plugin does not impact bundle size / load times
Get sign off from MV3 team

Manual Testing Steps

Load the extension
Check out functionality in general
All E2E tests pass so asking for manual review just to make sure nothing crazy happened.

Pre-Merge Checklist

PR template is filled out
~~IF this PR fixes a bug, a test that would have caught the bug has been added~~
~~PR is linked to the appropriate GitHub issue~~
PR has been added to the appropriate release Milestone

+ If there are functional changes:

Manual testing complete & passed
"Extension QA Board" label has been applied

metamaskbot · 2022-07-31T21:58:03Z

Builds ready [1e7d60c]

builds: chrome, firefox, opera
builds (beta): chrome, firefox, opera
builds (flask): chrome, firefox, opera
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
code coverage: Report
storybook: Storybook
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1604 ± 41 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	86	111	97	7	4
		domContentLoaded	1470	1784	1596	82	40
		load	1488	1806	1604	86	41
		domInteractive	1470	1784	1596	82	40

metamaskbot · 2022-07-31T23:26:08Z

Builds ready [90e52d4]

builds: chrome, firefox, opera
builds (beta): chrome, firefox, opera
builds (flask): chrome, firefox, opera
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
code coverage: Report
storybook: Storybook
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1606 ± 43 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	86	252	106	35	17
		domContentLoaded	1488	1871	1595	93	45
		load	1488	1871	1606	89	43
		domInteractive	1488	1871	1595	93	45

metamaskbot · 2022-08-01T14:41:42Z

Builds ready [5488aae]

builds: chrome, firefox, opera
builds (beta): chrome, firefox, opera
builds (flask): chrome, firefox, opera
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
code coverage: Report
storybook: Storybook
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1850 ± 91 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	94	2301	232	475	228
		domContentLoaded	1643	2305	1833	164	79
		load	1649	2424	1850	189	91
		domInteractive	1643	2305	1833	164	79

metamaskbot · 2022-08-01T16:29:52Z

Builds ready [433d87f]

builds: chrome, firefox, opera
builds (beta): chrome, firefox, opera
builds (flask): chrome, firefox, opera
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
code coverage: Report
storybook: Storybook
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1737 ± 54 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	85	194	111	31	15
		domContentLoaded	1548	1915	1710	98	47
		load	1548	1934	1737	112	54
		domInteractive	1548	1915	1710	98	47

jpuri

Changes look good, I also checked MV3 build artifacts to ensure that build changes have no effect on that.

brad-decker · 2022-08-04T14:40:37Z

babel.config.js

+    targets: {
+      browsers: ['chrome >= 66', 'firefox >= 68'],
+    },


@Gudahtt pinging you on this, just wanted to alert you of this change as it will likely impact #12847. This was changed in babel to support making the targets available to all plugins and presets instead of just preset-env.

metamaskbot · 2022-08-04T15:31:17Z

Builds ready [845d27d]

builds: chrome, firefox, opera
builds (beta): chrome, firefox, opera
builds (flask): chrome, firefox, opera
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
code coverage: Report
storybook: Storybook
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1631 ± 56 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	84	147	102	17	8
		domContentLoaded	1500	2054	1620	120	57
		load	1500	2054	1631	118	56
		domInteractive	1500	2054	1620	120	57

kumavis

looks good

georgewrmarshall

Not going to pretend I know a lot about build tooling but have checked storybook still works yarn storybook and the extension still runs yarn start.

brad-decker changed the title ~~WIP~~ Update Babel and dependencies Aug 1, 2022

brad-decker marked this pull request as ready for review August 1, 2022 16:48

brad-decker requested review from a team and kumavis as code owners August 1, 2022 16:48

brad-decker requested a review from georgewrmarshall August 1, 2022 16:48

jpuri previously approved these changes Aug 4, 2022

View reviewed changes

brad-decker added the needs-qa Label will automate into QA workspace label Aug 4, 2022

brad-decker added 2 commits August 4, 2022 09:06

update babel

eb57919

policy fix

845d27d

brad-decker dismissed jpuri’s stale review via 845d27d August 4, 2022 14:35

brad-decker force-pushed the update-babel branch from 433d87f to 845d27d Compare August 4, 2022 14:35

brad-decker commented Aug 4, 2022

View reviewed changes

kumavis approved these changes Aug 4, 2022

View reviewed changes

georgewrmarshall approved these changes Aug 4, 2022

View reviewed changes

brad-decker merged commit 7b42c54 into develop Aug 5, 2022

brad-decker deleted the update-babel branch August 5, 2022 15:04

github-actions bot locked and limited conversation to collaborators Aug 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Babel and dependencies #15392

Update Babel and dependencies #15392

brad-decker commented Jul 31, 2022 •

edited

Loading

metamaskbot commented Jul 31, 2022

metamaskbot commented Jul 31, 2022

metamaskbot commented Aug 1, 2022

metamaskbot commented Aug 1, 2022

jpuri left a comment

brad-decker Aug 4, 2022

metamaskbot commented Aug 4, 2022

kumavis left a comment

georgewrmarshall left a comment

Update Babel and dependencies #15392

Update Babel and dependencies #15392

Conversation

brad-decker commented Jul 31, 2022 • edited Loading

Explanation

More Information

Manual Testing Steps

Pre-Merge Checklist

+ If there are functional changes:

metamaskbot commented Jul 31, 2022

metamaskbot commented Jul 31, 2022

metamaskbot commented Aug 1, 2022

metamaskbot commented Aug 1, 2022

jpuri left a comment

Choose a reason for hiding this comment

brad-decker Aug 4, 2022

Choose a reason for hiding this comment

metamaskbot commented Aug 4, 2022

kumavis left a comment

Choose a reason for hiding this comment

georgewrmarshall left a comment

Choose a reason for hiding this comment

brad-decker commented Jul 31, 2022 •

edited

Loading