Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum browser versions #12847

Merged
merged 3 commits into from
Feb 24, 2023
Merged

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Nov 25, 2021

The minimum browser versions have been updated to Chromium v80 and Firefox v78.

Chromium v78 is >2 years old, and very few users use older versions than that.
Updated to v80 to provide support for optional chaining

Firefox v78 is the previous extended support release. The current Firefox extended support release is v91.

Related: #6805

Manual testing steps:

  • Ensure that the extension still works on versions equal to or above the new minimum versions.

@Gudahtt Gudahtt mentioned this pull request Nov 25, 2021
5 tasks
@Gudahtt Gudahtt marked this pull request as ready for review November 25, 2021 05:12
@Gudahtt Gudahtt requested a review from a team as a code owner November 25, 2021 05:12
@Gudahtt Gudahtt requested a review from hmalik88 November 25, 2021 05:12
@metamaskbot
Copy link
Collaborator

Builds ready [f2800dd]
Page Load Metrics (858 ± 32 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30687843819393
domContentLoaded77410098576732
load77510098586632
domInteractive77410098576732

hmalik88
hmalik88 previously approved these changes Nov 25, 2021
darkwing
darkwing previously approved these changes Nov 25, 2021
rekmarks
rekmarks previously approved these changes Nov 25, 2021
@Gudahtt
Copy link
Member Author

Gudahtt commented Nov 25, 2021

Apparently this might affect up to 1% of the userbase, though it's likely a bit lower than that. More details here: #6805 (comment)

@Gudahtt Gudahtt added the DO-NOT-MERGE Pull requests that should not be merged label Nov 25, 2021
@Gudahtt
Copy link
Member Author

Gudahtt commented Nov 25, 2021

I'm marking this as "DO-NOT-MERGE" for now, to give those away on holiday the chance to weigh in about whether we should do this now, or whether we should wait until after we add more in-app messaging asking users to update.

@darkwing
Copy link
Contributor

Idea that @Gudahtt and I were discussing was parsing the UA and, if the user is stuck on an old browser, displaying a persistent message on top of the home screen to let the user know they wont receive MM updates. We'd need that to get merged the release before this gets merged.

@Gudahtt
Copy link
Member Author

Gudahtt commented Oct 26, 2022

The issue #16283 has been created to track adding a notification warning users if we're about to drop support for their browser. That will unblock this PR.

app/manifest/v2/chrome.json Outdated Show resolved Hide resolved
babel.config.js Outdated Show resolved Hide resolved
digiwand
digiwand previously approved these changes Dec 13, 2022
Copy link
Contributor

@digiwand digiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it appears the DO-NOT-MERGE tag was added for the last holiday season and can be removed now - LGTM! 🎄

@Gudahtt Gudahtt force-pushed the update-minimum-browser-versions branch from 40cf533 to 1b954cf Compare February 23, 2023 21:44
The minimum browser versions have been updated to Chromium v80 and
Firefox v78.

Chromium v80 is >3 years old, and very few users use older versions
than that.

Firefox v78 is two extended support releases ago (v91 and v102 ar the
previous and current ESR releases).
@Gudahtt
Copy link
Member Author

Gudahtt commented Feb 23, 2023

Thanks for the review @digiwand ! This was blocked by #16283, but is unblocked now that that has been included in the v10.26.0 RC.

@Gudahtt Gudahtt removed blocked DO-NOT-MERGE Pull requests that should not be merged labels Feb 23, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [d6ccc71]
Page Load Metrics (1619 ± 61 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint101153124178
domContentLoaded12801765159211656
load12801864161912761
domInteractive12801765159211656
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -592 bytes
  • ui: -2763 bytes
  • common: -304 bytes

@Gudahtt Gudahtt merged commit 524ab66 into develop Feb 24, 2023
@Gudahtt Gudahtt deleted the update-minimum-browser-versions branch February 24, 2023 15:09
@github-actions github-actions bot locked and limited conversation to collaborators Feb 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants