-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update minimum browser versions #12847
Conversation
Builds ready [f2800dd]Page Load Metrics (858 ± 32 ms)
|
Apparently this might affect up to 1% of the userbase, though it's likely a bit lower than that. More details here: #6805 (comment) |
I'm marking this as "DO-NOT-MERGE" for now, to give those away on holiday the chance to weigh in about whether we should do this now, or whether we should wait until after we add more in-app messaging asking users to update. |
Idea that @Gudahtt and I were discussing was parsing the UA and, if the user is stuck on an old browser, displaying a persistent message on top of the home screen to let the user know they wont receive MM updates. We'd need that to get merged the release before this gets merged. |
The issue #16283 has been created to track adding a notification warning users if we're about to drop support for their browser. That will unblock this PR. |
f2800dd
to
fa54250
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it appears the DO-NOT-MERGE
tag was added for the last holiday season and can be removed now - LGTM! 🎄
40cf533
to
1b954cf
Compare
The minimum browser versions have been updated to Chromium v80 and Firefox v78. Chromium v80 is >3 years old, and very few users use older versions than that. Firefox v78 is two extended support releases ago (v91 and v102 ar the previous and current ESR releases).
1b954cf
to
baac6ae
Compare
Builds ready [d6ccc71]
Page Load Metrics (1619 ± 61 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
The minimum browser versions have been updated to Chromium v80 and Firefox v78.
Chromium v78 is >2 years old, and very few users use older versions than that.Updated to v80 to provide support for optional chaining
Firefox v78 is the previous extended support release. The current Firefox extended support release is v91.
Related: #6805
Manual testing steps: