Give the user ability to opt out of get balance batch request for all loaded accounts #16746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
pedronfigueiredo
changed the title
| @@ -83,24 +85,26 @@ export default class SecurityTab extends PureComponent { | |||
| ); | |||
| } | |||
|
|
|||
| renderMetaMetricsOptIn() { | |||
| renderIncomingTransactionsOptIn() { | |||
There was a problem hiding this comment.
github diff checker is a bit confused on this file, I simply reordered the render functions on this file and added a new one
pedronfigueiredo
force-pushed
the
fix-15169
branch
2 times, most recently
from
f1e4b6f to
342a8e5
Compare
brad-decker
previously approved these changes
Nov 30, 2022
There was a problem hiding this comment.
This looks good to me, tested locally and works well. Great work @pedronfigueiredo 🎉
pedronfigueiredo
changed the title
pedronfigueiredo
changed the title
|
Marking it as a draft until tomorrow to get the final copy. |
|
@pedronfigueiredo by default we let contributors with merge access merge their own PRs, but sometimes they do get merged by others. Marking as draft is appropriate here due to incoming changes but you can also flag with DO-NOT-MERGE when necessary to avoid others merging fully approved PRs. Example: #12847 (at least it has been fully approved multiple times in the past :P ) |
pedronfigueiredo
dismissed stale reviews from jpuri and brad-decker
via
e92ec03
pedronfigueiredo
force-pushed
the
fix-15169
branch
from
342a8e5 to
e92ec03
Compare
pedronfigueiredo
changed the title
pedronfigueiredo
force-pushed
the
fix-15169
branch
from
e92ec03 to
10a0070
Compare
Builds ready [145bf9a]
Page Load Metrics (2427 ± 154 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
highlights:storybook
|
Builds ready [c4dd37e]
Page Load Metrics (1856 ± 91 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
highlights:storybook
|
Builds ready [59598bb]
Page Load Metrics (2583 ± 319 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
highlights:storybook
|
danjm
approved these changes
Dec 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Adds ability for the user to opt-out of batching requests to get balances for all accounts in the wallet
Unit tests
Fixes [Bug]: Don't correlate accounts with RPC endpoint. #15169
Screenshots/Screencaps
Opting.out.of.batching.Network.Requests.for.user.privacy.1.mp4
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.