Improving approve transaction flow #17537
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
jpuri
force-pushed
the
approve_transaction_improvement
branch
from
d5ccc57 to
701d041
Compare
jpuri
force-pushed
the
approve_transaction_improvement
branch
from
553a4d3 to
71e9628
Compare
Builds ready [71e9628]
Page Load Metrics (1344 ± 105 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
digiwand
reviewed
Feb 3, 2023
jpuri
force-pushed
the
approve_transaction_improvement
branch
from
71e9628 to
88bb624
Compare
…/metamask-extension into approve_transaction_improvement
Builds ready [1a34761]
Page Load Metrics (1259 ± 121 ms)
Bundle size diffs
|
… approve_transaction_improvement
Builds ready [30e4be6]
Page Load Metrics (1317 ± 100 ms)
Bundle size diffs
|
jpuri
commented
Feb 7, 2023
| @@ -99,6 +108,7 @@ export default function TransactionDecoding({ to = '', inputData: data = '' }) { | |||
| } | |||
| } | |||
| })(); | |||
| return () => setMounted(false); | |||
| }, [t, from, to, network, data]); | |||
|
|
|||
| // *********************************************************** | |||
There was a problem hiding this comment.
This file's change are not directly related to task, but were needed to remove warnings from new test cases added.
jpuri
commented
Feb 7, 2023
| getByText(sendWithApproveTransaction.txParams.data), | ||
| ).toBeInTheDocument(); | ||
| }); | ||
| }); |
digiwand
previously approved these changes
Feb 9, 2023
Builds ready [66807f3]
Page Load Metrics (1379 ± 177 ms)
Bundle size diffs
|
digiwand
previously approved these changes
Feb 9, 2023
|
I've noticed that the recipient on the top header is pointing to the incorrect address. We should point to the Contract's address
|
|
I am not 100% confident on reviewing the code at this level but somehow I believe we could re-use some methods/screen that are implemented for the generic Contract Interaction case. With that I mean, taking the example of the Deposit function from the test-dapp, we call a contract function with value. In this case, the exact same result should happen (screen is the same with all the components), so maybe we could re-use some of that? Let me know if this makes sense to you deposit.mp4 |
segun
previously approved these changes
Feb 9, 2023
|
Hey @seaona : I fixed recipient address, can you plz retest. |
…/metamask-extension into approve_transaction_improvement
Builds ready [b76a311]
Page Load Metrics (1377 ± 141 ms)
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## develop #17537 +/- ##
===========================================
+ Coverage 61.96% 62.38% +0.41%
===========================================
Files 908 908
Lines 35137 35159 +22
Branches 8907 8919 +12
===========================================
+ Hits 21772 21931 +159
+ Misses 13365 13228 -137
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
I see the issue fixed @jpuri ! Nice work!! I just have a remaining question, I directed in slack and after this is clarified the PR should be ready |
|
Closing in favour of #17777 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve approve transaction flow
https://app.zenhub.com/workspaces/confirmations-6245e6e2348677001213b8d2/issues/gh/metamask/metamask-planning/317