Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change transaction type for send with approve transaction #17777

Merged
merged 4 commits into from
Feb 16, 2023

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Feb 16, 2023

@jpuri jpuri requested review from danjm and seaona February 16, 2023 06:57
@jpuri jpuri requested a review from a team as a code owner February 16, 2023 06:57
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri
Copy link
Contributor Author

jpuri commented Feb 16, 2023

Thanks @danjm , @seaona : this small fix seems to have done the magic:

Screenshot 2023-02-16 at 12 27 54 PM

Screenshot 2023-02-16 at 12 19 35 PM

@seaona
Copy link
Contributor

seaona commented Feb 16, 2023

@jpuri I've just QAd it and looks good 🔥

@metamaskbot
Copy link
Collaborator

Builds ready [b8982bd]
Page Load Metrics (1557 ± 46 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint97144111115
domContentLoaded1403170615418039
load1403179315579646
domInteractive1403170615418039
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 bytes
  • ui: 0 bytes
  • common: 73 bytes

@jpuri jpuri merged commit 41e2c2b into develop Feb 16, 2023
@jpuri jpuri deleted the send_with_approve branch February 16, 2023 14:53
@github-actions github-actions bot locked and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants