Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump snow 1.5.0 #17985

Merged
merged 11 commits into from
Mar 8, 2023
Merged

bump snow 1.5.0 #17985

merged 11 commits into from
Mar 8, 2023

Conversation

weizman
Copy link
Member

@weizman weizman commented Mar 5, 2023 •
edited
Loading

@weizman weizman mentioned this pull request Mar 5, 2023
Merged
digiwand
digiwand previously approved these changes Mar 6, 2023
View reviewed changes
@codecov
Copy link

codecov bot commented Mar 7, 2023 •
edited
Loading

Codecov Report

Merging #17985 (8bdd463) into develop (bfbd652) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #17985      +/-   ##
===========================================
- Coverage    63.45%   63.44%   -0.01%     
===========================================
  Files          903      903              
  Lines        35263    35263              
  Branches      8918     8918              
===========================================
- Hits         22373    22371       -2     
- Misses       12890    12892       +2
Impacted Files Coverage Δ
app/scripts/lib/segment/analytics.js 49.02% <0.00%> (-2.61%) ⬇️
app/scripts/lib/segment/index.js 78.05% <0.00%> (+4.88%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@weizman weizman marked this pull request as ready for review March 7, 2023 13:06
@weizman weizman requested a review from a team as a code owner March 7, 2023 13:06
@weizman weizman requested a review from digiwand March 7, 2023 13:06
naugtur
naugtur approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@naugtur naugtur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please squash

@weizman
Copy link
Member Author

weizman commented Mar 8, 2023

please squash

@naugtur always ;)

@weizman weizman merged commit 601e02c into MetaMask:develop Mar 8, 2023
@weizman weizman deleted the snow-1.5.0 branch March 8, 2023 11:09
@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@digiwand digiwand digiwand approved these changes

@naugtur naugtur naugtur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weizman @naugtur @digiwand