Avoid blob url for files downloads #17986
Merged
+7
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #17986 +/- ##
========================================
Coverage 63.44% 63.44%
========================================
Files 903 903
Lines 35267 35263 -4
Branches 8920 8918 -2
========================================
- Hits 22373 22371 -2
+ Misses 12894 12892 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
digiwand
previously approved these changes
Mar 6, 2023
kumavis
reviewed
Mar 7, 2023
| @@ -1,19 +1,23 @@ | |||
| import { getRandomFileName } from './util'; | |||
|
|
|||
ui/helpers/utils/export-utils.js
Outdated
| const elem = window.document.createElement('a'); | ||
| elem.target = '_blank'; | ||
| elem.href = window.URL.createObjectURL(blob); | ||
| elem.href = `data:${type};Base64,${b64}`; |
There was a problem hiding this comment.
can we just use btoa? https://developer.mozilla.org/en-US/docs/Web/API/btoa
There was a problem hiding this comment.
unfortunately btoa fails on special chars that we have in the exported json files that TextEncoder successfully deals with (I learned the hard way)
There was a problem hiding this comment.
interesting -- what about Buffer.from(xyz, 'utf8').toString('base64')
kumavis
reviewed
Mar 7, 2023
ui/helpers/utils/export-utils.js
Outdated
| @@ -1,19 +1,13 @@ | |||
| import { getRandomFileName } from './util'; | |||
|
|
|||
| export function exportAsFile(filename, data, type = 'text/csv') { | |||
| export async function exportAsFile(filename, data, type = 'text/csv') { | |||
kumavis
approved these changes
Mar 7, 2023
digiwand
approved these changes
Mar 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exportAsFileexportAsFilecreates a URL object from a Blob and downloads that (common trick)exportAsFilefunction, which will achieve the exact same goal but without the dangerous combo, but rather withdata:URI instead