ci: increase timeout for flaky e2e test steps #18189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
legobeat
force-pushed
the
test-e2e-flaky-increase-timeout
branch
from
6be289a
to
d306a41
Compare
legobeat
force-pushed
the
test-e2e-flaky-increase-timeout
branch
from
d306a41
to
ba1bb89
Compare
legobeat
force-pushed
the
test-e2e-flaky-increase-timeout
branch
from
ba1bb89
to
c1c9538
Compare
Codecov Report
@@ Coverage Diff @@
## develop #18189 +/- ##
===========================================
- Coverage 65.15% 65.15% -0.00%
===========================================
Files 936 936
Lines 35965 35963 -2
Branches 9231 9231
===========================================
- Hits 23432 23429 -3
- Misses 12533 12534 +1 see 6 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
timeouts not actually bumped this way - fix incoming |
|
we identified it should not be merged bc the api usage is not correct |
legobeat
force-pushed
the
test-e2e-flaky-increase-timeout
branch
2 times, most recently
from
89aa869
to
5be212f
Compare
Closed
legobeat
force-pushed
the
test-e2e-flaky-increase-timeout
branch
from
5be212f
to
049e075
Compare
* 1 - https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/39585/workflows/74a9b825-3fdb-466c-b794-e834415f8620/jobs/1089241 * 2 - https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/39676/workflows/d47a813f-54f6-4985-a2ae-f1cb23e3cd3e/jobs/1092394 - https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/39630/workflows/cb4d0496-31ea-4d20-885a-1926f7bda951/jobs/1090888 - https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/39673/workflows/54dd5fee-ac47-4444-b139-ff6a219277cf/jobs/1092277 * 3 https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/39655/workflows/4e05853a-2b80-4e4d-b828-fa3e18d38292/jobs/1091741
legobeat
force-pushed
the
test-e2e-flaky-increase-timeout
branch
from
049e075
to
95b3867
Compare
|
To see that this interface has effect: #18335 Though: #18335 (comment) |
Gudahtt
approved these changes
Apr 6, 2023
brad-decker
approved these changes
Apr 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
See:
Increases the timeouts for intermittently failing e2e steps (theory: prob heavy throttling in circleci workers)
Pre-merge author checklist
Pre-merge reviewer checklist