Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devdeps: mocha@7.2.0->9.2.2 #18195

Merged
merged 7 commits into from
Apr 14, 2023
Merged

Conversation

legobeat
Copy link
Contributor

Maintenance upgrade

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat marked this pull request as ready for review March 16, 2023 14:09
@legobeat legobeat requested a review from a team as a code owner March 16, 2023 14:09
@legobeat legobeat requested a review from segun March 16, 2023 14:09
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #18195 (d9fec39) into develop (79b2deb) will decrease coverage by 0.18%.
The diff coverage is n/a.

❗ Current head d9fec39 differs from pull request most recent head a94027d. Consider uploading reports for the commit a94027d to get more accurate results

@@             Coverage Diff             @@
##           develop   #18195      +/-   ##
===========================================
- Coverage    64.55%   64.37%   -0.18%     
===========================================
  Files          919      909      -10     
  Lines        35444    35267     -177     
  Branches      9119     9014     -105     
===========================================
- Hits         22880    22701     -179     
- Misses       12564    12566       +2     

see 55 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@legobeat
Copy link
Contributor Author

legobeat commented Mar 17, 2023

CI test-deps-audit error addressed separately in #18208

CI test-e2e-chrome error addressed in #18189

@socket-security
Copy link

socket-security bot commented Mar 25, 2023

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
eslint-plugin-mocha@10.1.0 None +1 lo1tuma
⬆️ Updated Package Version Diff Added Capability Access +/- Transitive Count Publisher
mocha@9.2.2 7.2.0...9.2.2 None +13/-25 juergba

@legobeat legobeat force-pushed the devdeps-mocha-9 branch 2 times, most recently from 54c35d7 to d98c17c Compare April 11, 2023 04:05
@legobeat legobeat requested review from jpuri and removed request for jpuri April 11, 2023 05:04
Maintenance upgrade

- Closes subdependency flat advisory
  - CVE-2020-36632 / GHSA-2j2x-2gpw-d8fm
- upgrade eslint-plugin-mocha to match
  - previously used `eslint-plugin-mocha` depended on mocha@^8.2.0
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kraouf3

This comment was marked as spam.

@kraouf3

This comment was marked as spam.

@legobeat legobeat merged commit 5d2c4c1 into MetaMask:develop Apr 14, 2023
@legobeat legobeat deleted the devdeps-mocha-9 branch April 14, 2023 01:49
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants