increase token symbol length to 64

[kyriediculous]

Description

Increase the token symbol length to 64.

With the increase of token derivatives, token symbol lengths are also increasing.

When adding tokens to the wallet by RPC call, Metamask expects the token symbol to match that on the contract and the symbol to be below 12 characters.

For many tokens (like tenderize's LSTs) this results in a deadlock if the token symbol on the contract has a greater length than 12.

Since Metamask already truncates display of long symbols on the UI, we could allow token symbols up to 64 characters (32 bytes), which equals a single word in the EVM.

This should both be a sufficient length for 99% of token symbols as well as provide a sufficient upper bound.

Related issues

Fixes: #9243

Same implementation as an earlier PR that increases the length to 12: #5816

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action:

Thank you for your submission, we really appreciate it. We ask that you read and sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just by adding a comment to this pull request with this exact sentence:

I have read the CLA Document and I hereby sign the CLA

By commenting with the above message you are agreeing to the terms of the CLA. Your account will be recorded as agreeing to our CLA so you don't need to sign it again for future contributions to this repository.

0 out of 1 committers have signed the CLA.
❌ @kyriediculous

[aspiers]

@kyriediculous Looks like you need to post a comment signing the CLA, as per above.

[fredwes]

Friendly bump @kyriediculous 🙏

[legobeat]

#17642 is very similar but also improves on the magic-number situation.

[github-actions]

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

[github-actions]

This PR was closed because there has been no follow up activity in the last 14 days. Thank you for your contributions.