feat: permit signature simulation info #24862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpuri
added
needs-dev-review
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #24862 +/- ##
===========================================
+ Coverage 65.73% 65.74% +0.02%
===========================================
Files 1369 1365 -4
Lines 54417 54274 -143
Branches 14161 14109 -52
===========================================
- Hits 35766 35681 -85
+ Misses 18651 18593 -58 ☔ View full report in Codecov by Sentry. |
Builds ready [11dc68b]
Page Load Metrics (888 ± 527 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [9d17164]
Page Load Metrics (1674 ± 689 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
digiwand
reviewed
Jun 7, 2024
| </ConfirmInfoRow> | ||
| </Box> | ||
| ); | ||
| }; |
There was a problem hiding this comment.
should the values be right aligned?
There was a problem hiding this comment.
Hey @digiwand : after certain with confirm row wraps, thus this is how it will look for wider values
There was a problem hiding this comment.
Derek had made some improvements on how we display long values within simulations here: #24036
Is this something we could re-use? Ideally, we have the same pattern in both places
There was a problem hiding this comment.
Yep that can be done, but I would prefer to address that in separate PR.
digiwand
reviewed
Jun 7, 2024
| </Box> | ||
| </ConfirmInfoRow> | ||
| </Box> | ||
| ); |
There was a problem hiding this comment.
The pill component does not appear to be aligned with the label
There was a problem hiding this comment.
- Confirm info row are center aligned and its hard to change for this specifically
digiwand
reviewed
Jun 7, 2024
| > | ||
| <ConfirmInfoRow | ||
| label={t('simulationDetailsTitle')} | ||
| tooltip={t('simulationDetailsTitleTooltip')} |
There was a problem hiding this comment.
- looks like figma users. "i" icon instead of "?" here
- I think we could add padding between the label and text below
There was a problem hiding this comment.
Again these are limitations with ConfirmInfoRow. We need to see if its ok to generically change this for all usages.
...ges/confirmations/components/confirm/info/typed-sign/permit-simulation/permit-simulation.tsx
Outdated
Show resolved
Hide resolved
…it-simulation/permit-simulation.tsx Co-authored-by: Ariella Vu <20778143+digiwand@users.noreply.github.com>
…k/metamask-extension into permit_signature_simulation_info
7 tasks
...ges/confirmations/components/confirm/info/typed-sign/permit-simulation/permit-simulation.tsx
Outdated
Show resolved
Hide resolved
...ges/confirmations/components/confirm/info/typed-sign/permit-simulation/permit-simulation.tsx
Outdated
Show resolved
Hide resolved
matthewwalsh0
approved these changes
Jun 12, 2024
pedronfigueiredo
approved these changes
Jun 12, 2024
Builds ready [966267e]
Page Load Metrics (135 ± 172 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [966267e]
Page Load Metrics (135 ± 172 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [df189d4]
Page Load Metrics (50 ± 4 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
github-actions
bot
removed
the
needs-dev-review
metamaskbot
added
the
release-12.1.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add simulation section to permit signatures
Related issues
Fixes: #24618, #24878
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist