-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Simulations on signature pages should be displayed only if preference is enabled #25186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpuri
added
confirmation-redesign
team-confirmations
Push issues to confirmations team
labels
Jun 10, 2024
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
matthewwalsh0
previously approved these changes
Jun 11, 2024
jpuri
force-pushed
the
fix_simulation_display
branch
from
June 12, 2024 10:11
18e0020
to
1c6b783
Compare
jpuri
force-pushed
the
fix_simulation_display
branch
from
June 12, 2024 12:16
1c6b783
to
899afae
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25186 +/- ##
========================================
Coverage 65.56% 65.56%
========================================
Files 1372 1373 +1
Lines 54486 54490 +4
Branches 14265 14265
========================================
+ Hits 35720 35724 +4
Misses 18766 18766 ☔ View full report in Codecov by Sentry. |
digiwand
reviewed
Jun 12, 2024
Builds ready [899afae]
Page Load Metrics (58 ± 15 ms)
Bundle size diffs
|
Co-authored-by: Ariella Vu <20778143+digiwand@users.noreply.github.com>
digiwand
previously approved these changes
Jun 12, 2024
Builds ready [f4a6e8f]
Page Load Metrics (50 ± 3 ms)
Bundle size diffs
|
pedronfigueiredo
previously approved these changes
Jun 12, 2024
Builds ready [3f0e61f]
Page Load Metrics (54 ± 12 ms)
Bundle size diffs
|
pedronfigueiredo
approved these changes
Jun 12, 2024
digiwand
approved these changes
Jun 12, 2024
metamaskbot
added
the
release-12.1.0
Issue or pull request that will be included in release 12.1.0
label
Jun 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
confirmation-redesign
release-12.1.0
Issue or pull request that will be included in release 12.1.0
team-confirmations
Push issues to confirmations team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR to address discussion here: #24862 (comment)
Simulations on signature pages should be displayed only if preference is enabled
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
NA
Pre-merge author checklist
Pre-merge reviewer checklist