Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Decouple the data deletion controller #24870

Merged
merged 3 commits into from
May 29, 2024
Merged

refactor: Decouple the data deletion controller #24870

merged 3 commits into from
May 29, 2024

Commits on May 29, 2024

  1. refactor: Decouple the data deletion controller 

    The `DataDeletionController` has been decoupled from the
`MetaMetricsController` by updating the constructor parameters to
expect just a function for getting the MetaMetrics ID, rather than the
entire `MetaMetricsController` state. This vastly simplifies the API
surface, making it easier to audit and test. It also prevents the
`DataDeletionController` from having the capability to make changes to
the `MetaMetricsController` state.

This is an improvement for #24503
    @Gudahtt
    Gudahtt committed May 29, 2024
    Configuration menu
    Copy the full SHA
    3e61f0b View commit details
    Browse the repository at this point in the history

  2. Fix lint errors

    @Gudahtt
    Gudahtt committed May 29, 2024
    Configuration menu
    Copy the full SHA
    78ec096 View commit details
    Browse the repository at this point in the history

  3. Avoid generating MetaMetrics ID if it doens't already exist

    @Gudahtt
    Gudahtt committed May 29, 2024
    Configuration menu
    Copy the full SHA
    c90863b View commit details
    Browse the repository at this point in the history